From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0BzoCipUzWnJjwIAWB0awg (envelope-from ) for ; Wed, 01 Apr 2026 13:21:46 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EnuDtmjK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0FA041E0BC; Wed, 01 Apr 2026 13:21:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3AD191E04F for ; Wed, 01 Apr 2026 13:21:45 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 4D1FE4BA23CA for ; Wed, 1 Apr 2026 17:21:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4D1FE4BA23CA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EnuDtmjK Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id C7B8C4BA23C0 for ; Wed, 1 Apr 2026 17:21:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7B8C4BA23C0 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C7B8C4BA23C0 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775064073; cv=none; b=DQwZW2cvtLCzl3zDyUHZ427pwWS2dFIwk07FX/q0yGKgEzym5AWUGyOkBW2YW5vj5nA96XvP7TvrpO3p26rVJPNmjUEumjnT+zsNbzz/QhKjSl6Vr+RYp68NmzDUp0A+Q+El4ZEDzDOaGmzKnI/o4+VYNNka06uYmu8xgJnVBVk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775064073; c=relaxed/simple; bh=qcO4Jrpb6MKy3Bth1AefKcKFLSS45mq42SwvGdipLMM=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=CA+dQEGbuoBYrEgw2aBaA0GsSIoYOQW7k7odObbdDGTEZ0fzP4zUZqAPVl7C5uwzpa/PZ6Ndm4yyz6iG4hLSJbbuX6Cx1o+qr0Lz9in4dfKfJjhYrogw15TmALg21Z0BeFAnKdFJ1GyeJMmWDb57U5TWQzrYbnkWuFK08iTr4dI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C7B8C4BA23C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775064073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XzI2d76CaHucnkKRiv6bX28d4s3a3ZlPz6rwIWMIUlc=; b=EnuDtmjKoKpekpSg9Zx/XczbGuc3kWILXXUG66VU3UXDybCq1dHOjY++Z8QGZL2Rm0uhWb jO1CbG+3etAFgYEV6hHcA0Zy8CXKtYM7dJRc1biqGBpVHnr8QZGcWDKdcU85MUf0wfbBoT 9Fy/w/wgz6itZ7+pDkbozWYGQltkaBE= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-132-GxYKAzOFM2m46EGmIshWfA-1; Wed, 01 Apr 2026 13:21:10 -0400 X-MC-Unique: GxYKAzOFM2m46EGmIshWfA-1 X-Mimecast-MFC-AGG-ID: GxYKAzOFM2m46EGmIshWfA_1775064070 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 03800180060F for ; Wed, 1 Apr 2026 17:21:10 +0000 (UTC) Received: from f42-zbm-amd (unknown [10.22.88.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4A5FD180035F; Wed, 1 Apr 2026 17:21:09 +0000 (UTC) Date: Wed, 1 Apr 2026 10:21:06 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: Re: [PATCH 2/2] gdb: move call to clear_symtab_users out from finish_new_objfile Message-ID: <20260401102106.463912ae@f42-zbm-amd> In-Reply-To: References: Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZISw2Dc2e-2ExO6Chyva1_p5SgPhmk1h908W16DA9lM_1775064070 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Andrew, Both parts LGTM. I have just one nit... On Tue, 31 Mar 2026 15:20:18 +0100 Andrew Burgess wrote: > + set_auto_load_safe_path $remote_python_file \ > + [file dirname ${objcopy_binfile}] > + gdb_load $objcopy_binfile I'd like to see a comment added for this call to set_auto_load_safe_path, perhaps something like: # Add directory because scripts are auto-loaded from the separate # .debug file (not the main executable), which resides alongside # it here. For both parts: Approved-by: Kevin Buettner