From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH 0/5] [gdb/testsuite] Use valnum_re more often
Date: Mon, 2 Feb 2026 10:05:32 -0700 [thread overview]
Message-ID: <20260202100532.23c61f53@f42-mesa-1> (raw)
In-Reply-To: <20260128120626.1032047-1-tdevries@suse.de>
On Wed, 28 Jan 2026 13:06:21 +0100
Tom de Vries <tdevries@suse.de> wrote:
> In the gdb testsuite we use the valnum_re regexp to match the '$1' in:
> ...
> (gdb) print 1
> $1 = 1
> (gdb)
> ...
>
> This series consists of valnum_re related patches, mostly using it more often.
>
> I started out writing a patch series using decimal and hex more often (and
> other related improvements), but put that on hold once I realized that:
> - I also wanted to use valnum_re more often, and
> - it doesn't make sense to first rewrite "\\\$\[0-9\]+" into "\\\$$decimal"
> and then into "$valnum_re".
>
> Tested on x86_64-linux. I've reviewed the changes in gdb.arch.
A very nice cleanup! Thanks for doing this!
I've looked over each patch in this series and all LGTM.
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2026-02-02 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 12:06 Tom de Vries
2026-01-28 12:06 ` [PATCH 1/5] [gdb/testsuite] Remove superfluous definition of valnum_re in gdb.base/commands.exp Tom de Vries
2026-01-28 12:06 ` [PATCH 2/5] [gdb/testsuite] Use valnum_re more often (part 1) Tom de Vries
2026-01-28 12:06 ` [PATCH 3/5] [gdb/testsuite] Use valnum_re more often (part 2) Tom de Vries
2026-01-28 12:06 ` [PATCH 4/5] [gdb/testsuite] Use valnum_re more often (part 3) Tom de Vries
2026-01-28 12:06 ` [PATCH 5/5] [gdb/testsuite] Use valnum_re more often (part 4) Tom de Vries
2026-02-02 17:05 ` Kevin Buettner [this message]
2026-02-03 11:14 ` [PATCH 0/5] [gdb/testsuite] Use valnum_re more often Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202100532.23c61f53@f42-mesa-1 \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox