[PATCH 1/5] [gdb/testsuite] Remove superfluous definition of valnum_re in gdb.base/commands.exp

[Tom de Vries <tdevries@suse.de>]

Regexp valnum_re is defined in lib/gdb.exp.

Remove the superfluous definition of valnum_re in gdb.base/commands.exp.

While we're at it, redefine valnum_re using subst_vars to reduce escaping.
---
 gdb/testsuite/gdb.base/commands.exp | 3 ---
 gdb/testsuite/lib/gdb.exp           | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/gdb/testsuite/gdb.base/commands.exp b/gdb/testsuite/gdb.base/commands.exp
index 2c6709f7ec5..9d46e5b029d 100644
--- a/gdb/testsuite/gdb.base/commands.exp
+++ b/gdb/testsuite/gdb.base/commands.exp
@@ -362,9 +362,6 @@ proc_with_prefix user_defined_command_test {} {
 	"" \
 	"enter commands"
 
-    global decimal
-    set valnum_re "\\\$$decimal"
-
     gdb_test \
 	{mycommand $foo} \
 	[multi_line \
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 23fe3b3424a..acef1ad6310 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -338,7 +338,7 @@ set tdlabel_re "(process|Thread|LWP)"
 
 # A regular expression that matches a value history number.
 # E.g., $1, $2, etc.
-set valnum_re "\\\$$decimal"
+set valnum_re [subst_vars {\$$decimal}]
 
 # A regular expression that matches a breakpoint hit with a breakpoint
 # having several code locations.
-- 
2.51.0