From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YWf0FqLZgGkwgiQAWB0awg (envelope-from ) for ; Mon, 02 Feb 2026 12:06:42 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YumwI8eX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 590711E0BA; Mon, 02 Feb 2026 12:06:42 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 09F121E08D for ; Mon, 02 Feb 2026 12:06:42 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 5AE444BB592C for ; Mon, 2 Feb 2026 17:06:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5AE444BB592C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YumwI8eX Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id EC4984BB58B1 for ; Mon, 2 Feb 2026 17:05:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EC4984BB58B1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EC4984BB58B1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770051943; cv=none; b=o8eE5IDFbckZofGN097jA/35xJUl5Io07KDcU1UtaVzPvmSsqjwA0mbeuEGAWQahZxH3NViUycL2zlixGIeP1X2IcsSasuX7cZYUJUGkS2Fci76916BDa00yLnqzFnnSNqn0tZPNm9pBVinChnEpXI1dRTN/oN3vq9i2FBMPf24= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770051943; c=relaxed/simple; bh=JFi8DfKYvPRvptlSScxlzjUSPJUQt9xmrBorROtRQ38=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ZbvwrkXRXbMNAq9m/nKbJJXGJ67BxUTZYRc++38o0/OTCKRqyrLRQGmW0MoDFWIsDiGTt4N8Nkw3ULGZI2bSltQ5QyvTePMEnHdFI27zLd+10XervyfY/7uF6tdEFb/kYLauJEJOaa3pHqCxu1J+DYdFQ8C6nOaMaRCKtjEZs8U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EC4984BB58B1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770051937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zdD0LS8nNbHAPWMPudeTXajJVjmgg49Umfq/CR6hIaI=; b=YumwI8eXXPoqk0uSLyXAi1ngTdVq1NPApqcHQsJ93Kat3wC7asQ05YmQJaaTxnZU15Rfnn epW2nO0VlFIV7g9Cqbxvto4rgPlUPytdRmixjc5HqH581+TNXdS9bdKRdmKkltzTEZVS7d 9jTNrq+Rz4zqKeBwZcnO12WApo0rOnc= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-bJbBTc6OOL6tmuzdJnTEPg-1; Mon, 02 Feb 2026 12:05:36 -0500 X-MC-Unique: bJbBTc6OOL6tmuzdJnTEPg-1 X-Mimecast-MFC-AGG-ID: bJbBTc6OOL6tmuzdJnTEPg_1770051935 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EE82719541B5; Mon, 2 Feb 2026 17:05:34 +0000 (UTC) Received: from f42-mesa-1 (unknown [10.22.64.64]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3B5941800109; Mon, 2 Feb 2026 17:05:34 +0000 (UTC) Date: Mon, 2 Feb 2026 10:05:32 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Tom de Vries Subject: Re: [PATCH 0/5] [gdb/testsuite] Use valnum_re more often Message-ID: <20260202100532.23c61f53@f42-mesa-1> In-Reply-To: <20260128120626.1032047-1-tdevries@suse.de> References: <20260128120626.1032047-1-tdevries@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4lXkaPlkOVVz0YLweOOO9jXBstYvkUErFdiH9JXJdcU_1770051935 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wed, 28 Jan 2026 13:06:21 +0100 Tom de Vries wrote: > In the gdb testsuite we use the valnum_re regexp to match the '$1' in: > ... > (gdb) print 1 > $1 = 1 > (gdb) > ... > > This series consists of valnum_re related patches, mostly using it more often. > > I started out writing a patch series using decimal and hex more often (and > other related improvements), but put that on hold once I realized that: > - I also wanted to use valnum_re more often, and > - it doesn't make sense to first rewrite "\\\$\[0-9\]+" into "\\\$$decimal" > and then into "$valnum_re". > > Tested on x86_64-linux. I've reviewed the changes in gdb.arch. A very nice cleanup! Thanks for doing this! I've looked over each patch in this series and all LGTM. Approved-by: Kevin Buettner