Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* New ARI warning Wed Jan  7 02:00:25 GMT 2026
@ 2026-01-07  2:00 GDB Administrator
  2026-01-07 18:06 ` Tom Tromey
  0 siblings, 1 reply; 5+ messages in thread
From: GDB Administrator @ 2026-01-07  2:00 UTC (permalink / raw)
  To: gdb-patches

340a341
> gdb/dwarf2/read.c:11496: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/dwarf2/read.c:11496:	  if (struct type *containing_type = die_containing_type (die, cu);	      containing_type != nullptr)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: New ARI warning Wed Jan  7 02:00:25 GMT 2026
  2026-01-07  2:00 New ARI warning Wed Jan 7 02:00:25 GMT 2026 GDB Administrator
@ 2026-01-07 18:06 ` Tom Tromey
  2026-01-09  4:04   ` Kevin Buettner
  0 siblings, 1 reply; 5+ messages in thread
From: Tom Tromey @ 2026-01-07 18:06 UTC (permalink / raw)
  To: gdb-patches

>>>>> GDB Administrator <gdbadmin@sourceware.org> writes:

> 340a341
>> gdb/dwarf2/read.c:11496: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
> gdb/dwarf2/read.c:11496:	  if (struct type *containing_type = die_containing_type (die, cu);	      containing_type != nullptr)

We should probably remove this ARI check; or even ARI itself.

Tom

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: New ARI warning Wed Jan  7 02:00:25 GMT 2026
  2026-01-07 18:06 ` Tom Tromey
@ 2026-01-09  4:04   ` Kevin Buettner
  2026-01-09  7:00     ` Simon Marchi
  0 siblings, 1 reply; 5+ messages in thread
From: Kevin Buettner @ 2026-01-09  4:04 UTC (permalink / raw)
  To: gdb-patches

On Wed, 07 Jan 2026 11:06:37 -0700
Tom Tromey <tom@tromey.com> wrote:

> >>>>> GDB Administrator <gdbadmin@sourceware.org> writes:  
> 
> > 340a341  
> >> gdb/dwarf2/read.c:11496: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)  
> > gdb/dwarf2/read.c:11496:	  if (struct type *containing_type = die_containing_type (die, cu);	      containing_type != nullptr)  
> 
> We should probably remove this ARI check; or even ARI itself.

I'm in favor of the latter.

Kevin


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: New ARI warning Wed Jan 7 02:00:25 GMT 2026
  2026-01-09  4:04   ` Kevin Buettner
@ 2026-01-09  7:00     ` Simon Marchi
  2026-01-26 17:14       ` Tom Tromey
  0 siblings, 1 reply; 5+ messages in thread
From: Simon Marchi @ 2026-01-09  7:00 UTC (permalink / raw)
  To: Kevin Buettner, gdb-patches



On 2026-01-08 23:04, Kevin Buettner wrote:
> On Wed, 07 Jan 2026 11:06:37 -0700
> Tom Tromey <tom@tromey.com> wrote:
> 
>>>>>>> GDB Administrator <gdbadmin@sourceware.org> writes:  
>>
>>> 340a341  
>>>> gdb/dwarf2/read.c:11496: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)  
>>> gdb/dwarf2/read.c:11496:	  if (struct type *containing_type = die_containing_type (die, cu);	      containing_type != nullptr)  
>>
>> We should probably remove this ARI check; or even ARI itself.
> 
> I'm in favor of the latter.

+1.

Simon

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: New ARI warning Wed Jan 7 02:00:25 GMT 2026
  2026-01-09  7:00     ` Simon Marchi
@ 2026-01-26 17:14       ` Tom Tromey
  0 siblings, 0 replies; 5+ messages in thread
From: Tom Tromey @ 2026-01-26 17:14 UTC (permalink / raw)
  To: Simon Marchi; +Cc: Kevin Buettner, gdb-patches

>>> We should probably remove this ARI check; or even ARI itself.

>> I'm in favor of the latter.

Simon> +1.

I filed a sourceware bug.

https://sourceware.org/bugzilla/show_bug.cgi?id=33842

Tom

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-01-26 17:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-07  2:00 New ARI warning Wed Jan 7 02:00:25 GMT 2026 GDB Administrator
2026-01-07 18:06 ` Tom Tromey
2026-01-09  4:04   ` Kevin Buettner
2026-01-09  7:00     ` Simon Marchi
2026-01-26 17:14       ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox