From: Kevin Buettner <kevinb@redhat.com>
To: "Sébastien Darche" <sdarche@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] fix gdb.server/server-kill.exp
Date: Fri, 3 Oct 2025 17:04:47 -0700 [thread overview]
Message-ID: <20251003170447.5aee6b3b@f41-zbm-amd> (raw)
In-Reply-To: <20250930190742.1615465-1-sdarche@efficios.com>
On Tue, 30 Sep 2025 15:07:41 -0400
Sébastien Darche <sdarche@efficios.com> wrote:
> A test case in gdb.server/server-kill.exp attempts to query the server
> status after the server it is connected to has been killed. The
> connection is reset as expected, but the regex on the error message
> seems to be out-of-date. The test expects:
>
> Remote communication error. Target disconnected: Connection reset by peer.
>
> But a modern build of gdb yields :
>
> Remote communication error. Target disconnected: error while reading: Connection reset by peer.
>
> I presume this is due to change 0da23004a064 ("Change serial_readchar to
> throw") which added exceptions to the control flow handling instead of
> relying on perror(). The exception error string inserts "error while
> reading" to the perror message.
>
> The test appeared to fail intermittently, sometimes matching the first
> part of the regex ("Remote connection closed"). It now passes
> consistently.
LGTM.
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2025-10-04 0:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 19:07 Sébastien Darche
2025-10-04 0:04 ` Kevin Buettner [this message]
2025-10-08 20:14 ` Sébastien Darche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251003170447.5aee6b3b@f41-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sdarche@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox