From: "Sébastien Darche" <sdarche@efficios.com>
To: gdb-patches@sourceware.org
Cc: "Sébastien Darche" <sdarche@efficios.com>
Subject: [PATCH] [gdb/testsuite] fix gdb.server/server-kill.exp
Date: Tue, 30 Sep 2025 15:07:41 -0400 [thread overview]
Message-ID: <20250930190742.1615465-1-sdarche@efficios.com> (raw)
A test case in gdb.server/server-kill.exp attempts to query the server
status after the server it is connected to has been killed. The
connection is reset as expected, but the regex on the error message
seems to be out-of-date. The test expects:
Remote communication error. Target disconnected: Connection reset by peer.
But a modern build of gdb yields :
Remote communication error. Target disconnected: error while reading: Connection reset by peer.
I presume this is due to change 0da23004a064 ("Change serial_readchar to
throw") which added exceptions to the control flow handling instead of
relying on perror(). The exception error string inserts "error while
reading" to the perror message.
The test appeared to fail intermittently, sometimes matching the first
part of the regex ("Remote connection closed"). It now passes
consistently.
Change-Id: I3bf364b5d4b56de67f9ca30e9d636d3bb1be4119
---
gdb/testsuite/gdb.server/server-kill.exp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp
index a9fcabb08ce..1d3e348944b 100644
--- a/gdb/testsuite/gdb.server/server-kill.exp
+++ b/gdb/testsuite/gdb.server/server-kill.exp
@@ -97,7 +97,7 @@ proc_with_prefix test_tstatus {} {
# Force GDB to talk with GDBserver, so that we can get the
# "connection closed" error.
- gdb_test "tstatus" {Remote connection closed|Remote communication error\. Target disconnected: Connection reset by peer\.}
+ gdb_test "tstatus" {Remote connection closed|Remote communication error\. Target disconnected: error while reading: Connection reset by peer\.}
}
# Test unwinding with no debug/unwind info, right after the connection
@@ -152,4 +152,3 @@ test_tstatus
test_unwind_nosyms
test_unwind_syms
test_stepi
-
--
2.51.0
next reply other threads:[~2025-09-30 19:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 19:07 Sébastien Darche [this message]
2025-10-04 0:04 ` Kevin Buettner
2025-10-08 20:14 ` Sébastien Darche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250930190742.1615465-1-sdarche@efficios.com \
--to=sdarche@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox