From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2lDSE6wq3GhkHBoAWB0awg (envelope-from ) for ; Tue, 30 Sep 2025 15:08:28 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=k6PjY+/D; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3A80E1E0B6; Tue, 30 Sep 2025 15:08:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 833DD1E04C for ; Tue, 30 Sep 2025 15:08:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B0F803857712 for ; Tue, 30 Sep 2025 19:08:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B0F803857712 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=k6PjY+/D Received: from smtpout.efficios.com (smtpout.efficios.com [IPv6:2607:5300:400:ed00::31e5]) by sourceware.org (Postfix) with ESMTPS id 441703858408 for ; Tue, 30 Sep 2025 19:07:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 441703858408 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 441703858408 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:5300:400:ed00::31e5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759259276; cv=none; b=bXO+l1I+htlpLn1FseQ4+ocA3RaHgdvjxSTPemPJEik6Wp8KBOm1jDYlVVSFT55yvfWSJczTbNyG2zvTxA/QAQHnRSrYTM7crTW/7paKGBKtUNutv+XBVgBv3wLT+mCcQSclhUpM7rzfRJfYPDPAnAxRj65qAtBNEhwji6QieN0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759259276; c=relaxed/simple; bh=mC9uKyNgYsoyt1oJQL/labjesz3eYLwsjzphz0dTMb4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=W5NuHrvjGFSHArx9Por3fGSqFQCgGK6ZnJg18asw//QWd5lzRZCJJMoebULv/naegTmjQ2NQ6Ht7ixia/mscAVSnk0qM2mTCHTSbLZ1X6MSOeiNKSd2VlElnwAqft+yvCQLtEVzDIu7jHpekYSZH3kspaqytNAotxHX+USDzjAA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 441703858408 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=smtpout1; t=1759259276; bh=IbjGphajjeXQz/gGfI12SWLDea9QZs+L7ZNOSOOMQnw=; h=From:To:Cc:Subject:Date:From; b=k6PjY+/DqBTjRindprUHNLjK/rsY00hLSKql2Qg6pqRbt0+b2+n/7vT7PFAISkUJx y4P5c82vTxx8HdcGRzUWROA2RL5oMXIcrk9KlZH9AGmAnCg5b9Sg+L3fGsNikxFZqc qM7eEiOnPPyT763h7s/JbidiT7BUq+m205xY3M2byPswO/BzB1GlrjC0nl+ZGFPKm/ WnVqABkRgEczIxRcbnEa1XsV46aj4NeFPaS7JHPNP4PfHCljm/m/sI7TfvFMYWZotD RGBhExTQZEKNCpav2icGThJfN3d4l8U/1h2np2xYgrykh740tqb8Au2g2J5YNcu4r9 4yTfunFPmL2ew== Received: from smtpout01.internal.efficios.com (mtl.efficios.com [216.120.195.104]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4cbnd76wZmzLsn for ; Tue, 30 Sep 2025 15:07:55 -0400 (EDT) Received: from epycamd.internal.efficios.com (epycamd.internal.efficios.com [172.18.0.16]) by smtpout01.internal.efficios.com (Postfix) with ESMTP id D33C82A054; Tue, 30 Sep 2025 15:07:55 -0400 (EDT) From: =?UTF-8?q?S=C3=A9bastien=20Darche?= To: gdb-patches@sourceware.org Cc: =?UTF-8?q?S=C3=A9bastien=20Darche?= Subject: [PATCH] [gdb/testsuite] fix gdb.server/server-kill.exp Date: Tue, 30 Sep 2025 15:07:41 -0400 Message-ID: <20250930190742.1615465-1-sdarche@efficios.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org A test case in gdb.server/server-kill.exp attempts to query the server status after the server it is connected to has been killed. The connection is reset as expected, but the regex on the error message seems to be out-of-date. The test expects: Remote communication error. Target disconnected: Connection reset by peer. But a modern build of gdb yields : Remote communication error. Target disconnected: error while reading: Connection reset by peer. I presume this is due to change 0da23004a064 ("Change serial_readchar to throw") which added exceptions to the control flow handling instead of relying on perror(). The exception error string inserts "error while reading" to the perror message. The test appeared to fail intermittently, sometimes matching the first part of the regex ("Remote connection closed"). It now passes consistently. Change-Id: I3bf364b5d4b56de67f9ca30e9d636d3bb1be4119 --- gdb/testsuite/gdb.server/server-kill.exp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp index a9fcabb08ce..1d3e348944b 100644 --- a/gdb/testsuite/gdb.server/server-kill.exp +++ b/gdb/testsuite/gdb.server/server-kill.exp @@ -97,7 +97,7 @@ proc_with_prefix test_tstatus {} { # Force GDB to talk with GDBserver, so that we can get the # "connection closed" error. - gdb_test "tstatus" {Remote connection closed|Remote communication error\. Target disconnected: Connection reset by peer\.} + gdb_test "tstatus" {Remote connection closed|Remote communication error\. Target disconnected: error while reading: Connection reset by peer\.} } # Test unwinding with no debug/unwind info, right after the connection @@ -152,4 +152,3 @@ test_tstatus test_unwind_nosyms test_unwind_syms test_stepi - -- 2.51.0