From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8X/rKwNl4GhVWB4AWB0awg (envelope-from ) for ; Fri, 03 Oct 2025 20:06:27 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EuxarzfU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B08081E04C; Fri, 03 Oct 2025 20:06:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 66FA01E04C for ; Fri, 03 Oct 2025 20:06:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F4198385771D for ; Sat, 4 Oct 2025 00:06:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F4198385771D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EuxarzfU Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id B65023857BB3 for ; Sat, 4 Oct 2025 00:04:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B65023857BB3 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B65023857BB3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759536299; cv=none; b=a/RfTb59OywgLREOrDi/MqR5Qth5nWqB1atyvMoif7218zbt/as0NbmTt0PXVWMVStvtDKx3+n5NstZltkG0H1C6LwS2ht/pmprlWjiBbWUpwiI+CSgxTAZZGRMeHBh4M3Zdpzti9TubLcrZShymo7O9f2JewYaAwwYiKFP/fBs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759536299; c=relaxed/simple; bh=74wuElH5hzs2DeBo0oo1csBfDARr8/Kkuyns4T/jiWs=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=I15lzzNdhmYJJctvpUUXnTnvDrO4/1ClmCuXnhYxssJn7iTXQaMZ7tMVdGpl+K10rnFPHdLbUHt30KJUFcZpzqekghGUFDfXlL3egxCVx33SiatuQBQqUfpw/3vX04LR4ct0SYXHNDZhX3Qaj0mNNAlULeQguibhAY5zJ/aynOk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B65023857BB3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759536299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eZjSHOe1I34Z2q6btBS3Rpv5u379JwHvLFRItYsAvKU=; b=EuxarzfUIXBUUgKaRXFP2GklIQCtiaF9tFWojDMthwyj2Qe614LlGSPulLT3N0ZDB6E9jj NVyp1YvMHkcgC0T59MWnKz5aB388dF6yJo5z/ZN7R+crq66JrN0XctnvnPjaGSz/QnYikx fct54EH2lQWE/vWggTjgxV2SuBdEdYM= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-258-Xno-yEtXPJiTdPg7ycerUA-1; Fri, 03 Oct 2025 20:04:56 -0400 X-MC-Unique: Xno-yEtXPJiTdPg7ycerUA-1 X-Mimecast-MFC-AGG-ID: Xno-yEtXPJiTdPg7ycerUA_1759536295 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2268E1800578; Sat, 4 Oct 2025 00:04:55 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.64.96]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 164583000198; Sat, 4 Oct 2025 00:04:53 +0000 (UTC) Date: Fri, 3 Oct 2025 17:04:47 -0700 From: Kevin Buettner To: =?ISO-8859-1?Q?S=E9bastien?= Darche Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/testsuite] fix gdb.server/server-kill.exp Message-ID: <20251003170447.5aee6b3b@f41-zbm-amd> In-Reply-To: <20250930190742.1615465-1-sdarche@efficios.com> References: <20250930190742.1615465-1-sdarche@efficios.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: I1LY1NuZNDe8yytxN9y5E8M1Hz32e21R5e75QFGNbTk_1759536295 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tue, 30 Sep 2025 15:07:41 -0400 S=C3=A9bastien Darche wrote: > A test case in gdb.server/server-kill.exp attempts to query the server > status after the server it is connected to has been killed. The > connection is reset as expected, but the regex on the error message > seems to be out-of-date. The test expects: >=20 > =09Remote communication error. Target disconnected: Connection reset by = peer. >=20 > But a modern build of gdb yields : >=20 > =09Remote communication error. Target disconnected: error while reading:= Connection reset by peer. >=20 > I presume this is due to change 0da23004a064 ("Change serial_readchar to > throw") which added exceptions to the control flow handling instead of > relying on perror(). The exception error string inserts "error while > reading" to the perror message. >=20 > The test appeared to fail intermittently, sometimes matching the first > part of the regex ("Remote connection closed"). It now passes > consistently. LGTM. Approved-by: Kevin Buettner