From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] Fix crash in f-typeprint.c
Date: Mon, 22 Sep 2025 17:50:36 -0700 [thread overview]
Message-ID: <20250922175036.25f6d23f@f41-zbm-amd> (raw)
In-Reply-To: <87y0q8et8o.fsf@tromey.com>
On Sat, 20 Sep 2025 14:58:31 -0600
Tom Tromey <tom@tromey.com> wrote:
> >> I don't know but this change does preserve what happened before the
> >> change to gdb_puts.
>
> Kevin> Since it fixes a crash and preserves the original behavior...
>
> Well, I took another look and I think that moving the space-printing
> into the same 'if' seems ok. It doesn't cause any test regressions
> either.
>
> Here's the updated version, let me know what you think.
Yeah, I like this one better.
It still has my approval...
Kevin
next prev parent reply other threads:[~2025-09-23 0:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-13 19:48 Tom Tromey
2025-09-13 21:48 ` Kevin Buettner
2025-09-13 22:29 ` Tom Tromey
2025-09-15 16:26 ` Kevin Buettner
2025-09-20 20:58 ` Tom Tromey
2025-09-23 0:50 ` Kevin Buettner [this message]
2025-09-23 18:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922175036.25f6d23f@f41-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox