From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2cN0Ml3v0WjerA4AWB0awg (envelope-from ) for ; Mon, 22 Sep 2025 20:52:45 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NJsnFYY1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B54A51E0BA; Mon, 22 Sep 2025 20:52:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1603E1E04C for ; Mon, 22 Sep 2025 20:52:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9A94B3858D1E for ; Tue, 23 Sep 2025 00:52:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A94B3858D1E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NJsnFYY1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 768CE3858D1E for ; Tue, 23 Sep 2025 00:50:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 768CE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 768CE3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758588644; cv=none; b=nljkmqJPTWWWxcrXNogITQMtKOy2XHuCv6OJYidOqvFr5odutbO0/gNiNRVWCF/JDgMdoxrvIOjOG2b5pXD+xOA0knhZ1NIyBsZUL8yjZzJLCjcj/I+Dooiknb0OuUs7JhEbKG5ea+cxBw0E0BOheXWpLF8JYaxRoKv4+ReAou8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758588644; c=relaxed/simple; bh=88tP72m8Mg7WioYNL/MMK5ZCYEOATOhC9//njgTWr0c=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=apc5Y70RSXVxQgctXdp9+5dE02I4IFTevk7siQNjIUG6c1qinWl5pLClnLCO7ITlIyMoc76BmYzspx14lHsl/CZPEbwb8oLIdMzl7EXTbWChPCnj2q+HPScQTsWPNMZ8G+FnQWYrGBdV13DGpH/5Eigqi2Ctjkyv3zf8Kx7iEMs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 768CE3858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758588644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zd5+UHYjsQ6AZy5t79ZIPXFv+/n6kh+8L0WHfNWA7KA=; b=NJsnFYY1KXLK62bOpv9X/OhoeMkJYT19+sJY+IQmqdUWeKfA4LvE8Tbsjxf02rjVvYkvIh Pl4v6N0OGdUs3TdSFtO4g61aoivYHC3WqmEKCB6uuJ/7Cr+03qhOj7gtDGM9ZmxFYE/BzS 2FtSD87XQn+iGgcSCvWdKyNvl+/RxLg= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-125-WFNYRpeeNs-vwZQ06QjY4w-1; Mon, 22 Sep 2025 20:50:42 -0400 X-MC-Unique: WFNYRpeeNs-vwZQ06QjY4w-1 X-Mimecast-MFC-AGG-ID: WFNYRpeeNs-vwZQ06QjY4w_1758588641 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A36C419560AD; Tue, 23 Sep 2025 00:50:41 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.64.42]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B023D1800447; Tue, 23 Sep 2025 00:50:40 +0000 (UTC) Date: Mon, 22 Sep 2025 17:50:36 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH] Fix crash in f-typeprint.c Message-ID: <20250922175036.25f6d23f@f41-zbm-amd> In-Reply-To: <87y0q8et8o.fsf@tromey.com> References: <20250913194811.933550-1-tom@tromey.com> <20250913144716.5ecd1209@f41-zbm-amd> <87o6ref0kq.fsf@tromey.com> <20250915092635.0b406689@f41-zbm-amd> <87y0q8et8o.fsf@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wBLmneCuBr6SnPDFAFwozuGywcGFYQ5dZzYcb1bEtM8_1758588641 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Sat, 20 Sep 2025 14:58:31 -0600 Tom Tromey wrote: > >> I don't know but this change does preserve what happened before the > >> change to gdb_puts. > > Kevin> Since it fixes a crash and preserves the original behavior... > > Well, I took another look and I think that moving the space-printing > into the same 'if' seems ok. It doesn't cause any test regressions > either. > > Here's the updated version, let me know what you think. Yeah, I like this one better. It still has my approval... Kevin