From: Kevin Buettner <kevinb@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix crash in f-typeprint.c
Date: Mon, 15 Sep 2025 09:26:35 -0700 [thread overview]
Message-ID: <20250915092635.0b406689@f41-zbm-amd> (raw)
In-Reply-To: <87o6ref0kq.fsf@tromey.com>
On Sat, 13 Sep 2025 16:29:41 -0600
Tom Tromey <tom@tromey.com> wrote:
> >>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
>
> >> gdb_puts (" ", stream);
> >>
> >> - gdb_puts (type->name (), stream);
> >> + if (type->name () != nullptr)
> >> + gdb_puts (type->name (), stream);
>
> Kevin> If you can't print the type, I'm wondering if it makes sense to
> Kevin> print the space before it? (I.e. look at the gdb_puts a few lines
> Kevin> above...)
>
> I don't know but this change does preserve what happened before the
> change to gdb_puts.
Since it fixes a crash and preserves the original behavior...
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2025-09-15 16:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-13 19:48 Tom Tromey
2025-09-13 21:48 ` Kevin Buettner
2025-09-13 22:29 ` Tom Tromey
2025-09-15 16:26 ` Kevin Buettner [this message]
2025-09-20 20:58 ` Tom Tromey
2025-09-23 0:50 ` Kevin Buettner
2025-09-23 18:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915092635.0b406689@f41-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox