From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 13CzK/k+yGg0lQUAWB0awg (envelope-from ) for ; Mon, 15 Sep 2025 12:29:45 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Zoc1s+1F; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9947C1E04C; Mon, 15 Sep 2025 12:29:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B039C1E04C for ; Mon, 15 Sep 2025 12:29:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 069A03858C36 for ; Mon, 15 Sep 2025 16:29:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 069A03858C36 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Zoc1s+1F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id E9F4D3858D1E for ; Mon, 15 Sep 2025 16:26:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E9F4D3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E9F4D3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757953611; cv=none; b=WNcf2jCUeOLdro2zqaJwA1Pj3v0x6k/8WN3qRX/t0dv1ka3vXnm4HS5gaFygLsk7EAusNwnkOu+al8tvsbPDGwwG8T8ufNxkH2eOdsfAA2Q2kCTyLWUFjj+iuH6oPjXKc/rJTKOAyqNT9ED/r5arQmQ9gDy/0k1bPRnlbdGFPv0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757953611; c=relaxed/simple; bh=2BfPpKrTHoUaPdLUHEn3qtESwJ8uI5m8BuL3yA30LMs=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=czfg4INr2d474yqTlTw1Z72/zV8IqvGUE0bG8Vj+Oj+0sPyqQdOHyGg466otzG00WJCPxQu/7leAuSgiW2iQES1P+uRTG6pKbjtlzC7Vp6irFr92UZgsNn6okZtRGP05RaShDOQn11M3qAEkuRR7qfYs/vVYXT7/Ikc5+l5W7RU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E9F4D3858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757953605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=biczkwffviz6mCR/h7hYu4MUXBXa49uZTQXjlGHHqlg=; b=Zoc1s+1FS8aVgRNx7m/qpKP+sJywV36epaNvb2HvJ1uIg+akqLitTsvSXxDS57HDiAa7WD QYSfer8NuWW3bsaI5IE/TX8L7S+sJDD6Q23HmoHAHm2rw6mlVqzTUC4NOVjyBHSyWRLiAb P8mA9yMmgFvaObF/JkR67e+JF9Yb3XA= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-i2drsmhIMgmASaH6snEbXA-1; Mon, 15 Sep 2025 12:26:44 -0400 X-MC-Unique: i2drsmhIMgmASaH6snEbXA-1 X-Mimecast-MFC-AGG-ID: i2drsmhIMgmASaH6snEbXA_1757953603 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5D85E19107E2; Mon, 15 Sep 2025 16:26:43 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.64.42]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8BC391800451; Mon, 15 Sep 2025 16:26:42 +0000 (UTC) Date: Mon, 15 Sep 2025 09:26:35 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix crash in f-typeprint.c Message-ID: <20250915092635.0b406689@f41-zbm-amd> In-Reply-To: <87o6ref0kq.fsf@tromey.com> References: <20250913194811.933550-1-tom@tromey.com> <20250913144716.5ecd1209@f41-zbm-amd> <87o6ref0kq.fsf@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ku_xw5k-81ILzEkj2V0oS5-_wFzWLiadaa4xStzc6Ao_1757953603 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Sat, 13 Sep 2025 16:29:41 -0600 Tom Tromey wrote: > >>>>> "Kevin" == Kevin Buettner writes: > > >> gdb_puts (" ", stream); > >> > >> - gdb_puts (type->name (), stream); > >> + if (type->name () != nullptr) > >> + gdb_puts (type->name (), stream); > > Kevin> If you can't print the type, I'm wondering if it makes sense to > Kevin> print the space before it? (I.e. look at the gdb_puts a few lines > Kevin> above...) > > I don't know but this change does preserve what happened before the > change to gdb_puts. Since it fixes a crash and preserves the original behavior... Approved-by: Kevin Buettner