From: Kevin Buettner <kevinb@redhat.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Adjust gdb.base/bp-cond-failure.exp for Cygwin
Date: Fri, 6 Jun 2025 10:21:33 -0700 [thread overview]
Message-ID: <20250606102133.6b148982@f41-zbm-amd> (raw)
In-Reply-To: <20250606165219.968227-1-pedro@palves.net>
On Fri, 6 Jun 2025 17:52:19 +0100
Pedro Alves <pedro@palves.net> wrote:
> Currently on Cygwin, I get:
>
> Running /home/alves/gdb/src/gdb/testsuite/gdb.base/bp-cond-failure.exp
> ... FAIL: gdb.base/bp-cond-failure.exp: access_type=char: cond_eval=auto:
> multi-loc: continue FAIL: gdb.base/bp-cond-failure.exp: access_type=char:
> cond_eval=auto: single-loc: continue FAIL: gdb.base/bp-cond-failure.exp:
> access_type=short: cond_eval=auto: multi-loc: continue FAIL:
> gdb.base/bp-cond-failure.exp: access_type=short: cond_eval=auto:
> single-loc: continue FAIL: gdb.base/bp-cond-failure.exp: access_type=int:
> cond_eval=auto: multi-loc: continue FAIL: gdb.base/bp-cond-failure.exp:
> access_type=int: cond_eval=auto: single-loc: continue FAIL:
> gdb.base/bp-cond-failure.exp: access_type=long long: cond_eval=auto:
> multi-loc: continue FAIL: gdb.base/bp-cond-failure.exp: access_type=long
> long: cond_eval=auto: single-loc: continue
>
> On GNU/Linux, we see:
>
> Breakpoint 2.1, foo () at
> .../src/gdb/testsuite/gdb.base/bp-cond-failure.c:21 21 return 0;
> /* Multi-location breakpoint here. */ (gdb) PASS:
> gdb.base/bp-cond-failure.exp: access_type=char: cond_eval=auto:
> multi-loc: continue
>
> While on Cygwin, we see:
>
> Thread 1 "bp-cond-failure" hit Breakpoint 2.1, foo () at
> .../src/gdb/testsuite/gdb.base/bp-cond-failure.c:21 21 return 0;
> /* Multi-location breakpoint here. */ (gdb) FAIL:
> gdb.base/bp-cond-failure.exp: access_type=char: cond_eval=auto:
> multi-loc: continue
>
> The difference is the "Thread 1" part in the beginning of the quoted
> output. It appears on Cygwin, but not on Linux. That's because on
> Cygwin, all inferiors are multi-threaded, because both Windows and the
> Cygwin runtime spawn a few helper threads.
>
> Fix this by adjusting the gdb.base/bp-cond-failure.exp testcase to
> work with either single- or multi-threaded inferiors.
>
> The testcase passes cleanly for me after this.
LGTM.
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2025-06-06 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 16:52 Pedro Alves
2025-06-06 17:21 ` Kevin Buettner [this message]
2025-06-09 16:39 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250606102133.6b148982@f41-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox