From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8v6HEMojQ2gDgQMAWB0awg (envelope-from ) for ; Fri, 06 Jun 2025 13:22:18 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=S7g5jAFX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2DC241E11C; Fri, 6 Jun 2025 13:22:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8726A1E0C2 for ; Fri, 6 Jun 2025 13:22:17 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13D03385AC36 for ; Fri, 6 Jun 2025 17:22:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 13D03385AC36 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=S7g5jAFX Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 298DB3857B84 for ; Fri, 6 Jun 2025 17:21:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 298DB3857B84 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 298DB3857B84 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749230503; cv=none; b=l1WXaFpqrPPHFo1Yhfb6PYPfvCCvziTLe16EzZBAs0vNbDBbORbkUGT2Kley7/jXM52hCt7Vp8S5At+tQow+u0UvbJYbEy8yJ5wZ+K9ylwWLTJs9G5vbVYlZImKEXp3Z8ssMltYkRzhAB3bggCtaQDfd38JeNWlTu1mXjo65BjI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749230503; c=relaxed/simple; bh=mBZhNt0P2tuj24QADMfYGmSK6lkc0RRvIhRO09kNJe0=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=auMH8KZO7OwK+v4HF4emb7q6dTL/v0O8pmPblOoYeveLUxg+NWRUzbR1hzPyRmdrxyRZvh6Bo+WAW4P/ewMTV0ahNIpOqe2YMPiM8W4IC7x2Vz4dXLw5SQa3m003KE3C25NzKfk2lDNwvdwUkE4uX7ZWGrhRyNF/IWIlWa1Lnvo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 298DB3857B84 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749230502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/n4XtT/a4dETPkbW+8/R57j6M/9fXDmkWCFY6E0rlU4=; b=S7g5jAFXjgL2YzsS2CO+9nnxa+D2AHuC/GvfpcH+EQMT2VGeq7CEgdHzJ1zMPvgM1lQIty fp6Xv9Xazr7IwmWAxrIJteH+ENMa2L+4YPyc3OAKR+BhTzK5zpXLmjMkjiZ7sJneCSFmC+ wqQSPnmbNUcTCLBLzdfdbXWuWEd9oPA= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-FwdA1SpoPYCXAHVpExOvmw-1; Fri, 06 Jun 2025 13:21:39 -0400 X-MC-Unique: FwdA1SpoPYCXAHVpExOvmw-1 X-Mimecast-MFC-AGG-ID: FwdA1SpoPYCXAHVpExOvmw_1749230499 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D44A219560BA; Fri, 6 Jun 2025 17:21:38 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.88.9]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0904119560B2; Fri, 6 Jun 2025 17:21:37 +0000 (UTC) Date: Fri, 6 Jun 2025 10:21:33 -0700 From: Kevin Buettner To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Adjust gdb.base/bp-cond-failure.exp for Cygwin Message-ID: <20250606102133.6b148982@f41-zbm-amd> In-Reply-To: <20250606165219.968227-1-pedro@palves.net> References: <20250606165219.968227-1-pedro@palves.net> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: u6tmSf4dDFbFD2hrUZ78z9cht0PgVDkzkJ_haLC6U-w_1749230499 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Fri, 6 Jun 2025 17:52:19 +0100 Pedro Alves wrote: > Currently on Cygwin, I get: > > Running /home/alves/gdb/src/gdb/testsuite/gdb.base/bp-cond-failure.exp > ... FAIL: gdb.base/bp-cond-failure.exp: access_type=char: cond_eval=auto: > multi-loc: continue FAIL: gdb.base/bp-cond-failure.exp: access_type=char: > cond_eval=auto: single-loc: continue FAIL: gdb.base/bp-cond-failure.exp: > access_type=short: cond_eval=auto: multi-loc: continue FAIL: > gdb.base/bp-cond-failure.exp: access_type=short: cond_eval=auto: > single-loc: continue FAIL: gdb.base/bp-cond-failure.exp: access_type=int: > cond_eval=auto: multi-loc: continue FAIL: gdb.base/bp-cond-failure.exp: > access_type=int: cond_eval=auto: single-loc: continue FAIL: > gdb.base/bp-cond-failure.exp: access_type=long long: cond_eval=auto: > multi-loc: continue FAIL: gdb.base/bp-cond-failure.exp: access_type=long > long: cond_eval=auto: single-loc: continue > > On GNU/Linux, we see: > > Breakpoint 2.1, foo () at > .../src/gdb/testsuite/gdb.base/bp-cond-failure.c:21 21 return 0; > /* Multi-location breakpoint here. */ (gdb) PASS: > gdb.base/bp-cond-failure.exp: access_type=char: cond_eval=auto: > multi-loc: continue > > While on Cygwin, we see: > > Thread 1 "bp-cond-failure" hit Breakpoint 2.1, foo () at > .../src/gdb/testsuite/gdb.base/bp-cond-failure.c:21 21 return 0; > /* Multi-location breakpoint here. */ (gdb) FAIL: > gdb.base/bp-cond-failure.exp: access_type=char: cond_eval=auto: > multi-loc: continue > > The difference is the "Thread 1" part in the beginning of the quoted > output. It appears on Cygwin, but not on Linux. That's because on > Cygwin, all inferiors are multi-threaded, because both Windows and the > Cygwin runtime spawn a few helper threads. > > Fix this by adjusting the gdb.base/bp-cond-failure.exp testcase to > work with either single- or multi-threaded inferiors. > > The testcase passes cleanly for me after this. LGTM. Approved-by: Kevin Buettner