From: Milica Matic <milicamatic05@gmail.com>
To: gdb-patches@sourceware.org
Cc: milica.matic@htecgroup.com, simark@simark.ca, cfu@wavecomp.com,
aburgess@redhat.com, kevinb@redhat.com, macro@orcam.me.uk,
djordje.todorovic@htecgroup.com,
Faraz Shahbazker <fshahbazker@wavecomp.com>
Subject: [PATCH 18/21] Fix failing test cases for linux and 64-bit target
Date: Fri, 13 Dec 2024 16:53:25 +0100 [thread overview]
Message-ID: <20241213155328.406003-20-milica.matic@htecgroup.com> (raw)
In-Reply-To: <20241213155328.406003-1-milica.matic@htecgroup.com>
From: Faraz Shahbazker <fshahbazker@wavecomp.com>
Fixing tests for the MIPS architecture by adding a .space marker
to generate terminal sequences, updating test outputs, fixing
relocations, and enabling the use of 32-bit and 64-bit ABIs for
precise testing.
Cherry-picked 7abff2b
from https://github.com/MIPS/binutils-gdb
Signed-off-by: Faraz Shahbazker <fshahbazker@wavecomp.com>
Signed-off-by: Milica Matic <milica.matic@htecgroup.com>
gas/
* gas/testsuite/gas/mips/micromips.s: Add .space
marker to generate terminal sequence.
* gas/testsuite/gas/mips/micromipsr6@micromips.d: Update reference
output to match.
* gas/testsuite/gas/mips/llpscp-32-micromips.d: Set 32-bit ABI to
enable building with 64-bit default tools.
* gas/testsuite/gas/mips/llpscp-64-micromips.d: Fix relocations
to be section relative and force the ABI to n32.
---
gas/testsuite/gas/mips/llpscp-32-micromips.d | 2 +-
gas/testsuite/gas/mips/llpscp-64-micromips.d | 16 ++++++++--------
gas/testsuite/gas/mips/micromips.s | 4 +++-
gas/testsuite/gas/mips/micromipsr6@micromips.d | 3 +--
gas/testsuite/gas/mips/mips.exp | 2 ++
5 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/gas/testsuite/gas/mips/llpscp-32-micromips.d b/gas/testsuite/gas/mips/llpscp-32-micromips.d
index 36462f38599..52a22e8a91c 100644
--- a/gas/testsuite/gas/mips/llpscp-32-micromips.d
+++ b/gas/testsuite/gas/mips/llpscp-32-micromips.d
@@ -1,5 +1,5 @@
#objdump: -dr
-#as: -mips32r6 -mmicromips -meva
+#as: -32 -mips32r6 -mmicromips -meva
#name: Paired LL/SC for micromipsr6
#source: llpscp-32.s
diff --git a/gas/testsuite/gas/mips/llpscp-64-micromips.d b/gas/testsuite/gas/mips/llpscp-64-micromips.d
index 984197211c0..08416f260bf 100644
--- a/gas/testsuite/gas/mips/llpscp-64-micromips.d
+++ b/gas/testsuite/gas/mips/llpscp-64-micromips.d
@@ -1,5 +1,5 @@
#objdump: -dr
-#as: -mips64r6 -mmicromips
+#as: -mips64r6 -mmicromips -64 -mabi=n32
#name: Paired LL/SC for micromips mips64r6
#source: llpscp-64.s
@@ -13,16 +13,16 @@ Disassembly of section \.text:
8: 3044 1234 addiu v0,a0,4660
c: 6042 5000 lldp v0,zero,v0
10: 3062 0000 addiu v1,v0,0
- 10: R_MICROMIPS_LO16 sync_mem
+ 10: R_MICROMIPS_LO16 \.data
14: 6043 5030 lldp v0,v1,v1
18: 1040 0123 lui v0,0x123
1c: 0062 1150 addu v0,v0,v1
20: 3042 4567 addiu v0,v0,17767
24: 6042 5030 lldp v0,v1,v0
28: 1020 0000 lui at,0x0
- 28: R_MICROMIPS_HI16 sync_mem
+ 28: R_MICROMIPS_HI16 \.data
2c: 3021 0000 addiu at,at,0
- 2c: R_MICROMIPS_LO16 sync_mem
+ 2c: R_MICROMIPS_LO16 \.data
30: 0081 0950 addu at,at,a0
34: 6001 5000 lldp zero,zero,at
38: 6044 d030 scdp v0,v1,a0
@@ -30,16 +30,16 @@ Disassembly of section \.text:
40: 3024 1234 addiu at,a0,4660
44: 6041 d000 scdp v0,zero,at
48: 3022 0000 addiu at,v0,0
- 48: R_MICROMIPS_LO16 sync_mem
+ 48: R_MICROMIPS_LO16 \.data
4c: 6041 d030 scdp v0,v1,at
50: 1020 0123 lui at,0x123
54: 0061 0950 addu at,at,v1
58: 3021 4567 addiu at,at,17767
5c: 6041 d030 scdp v0,v1,at
60: 1020 0000 lui at,0x0
- 60: R_MICROMIPS_HI16 sync_mem
+ 60: R_MICROMIPS_HI16 .data
64: 3021 0000 addiu at,at,0
- 64: R_MICROMIPS_LO16 sync_mem
+ 64: R_MICROMIPS_LO16 \.data
68: 0081 0950 addu at,at,a0
6c: 6001 d000 scdp zero,zero,at
- ...
+ \.\.\.
diff --git a/gas/testsuite/gas/mips/micromips.s b/gas/testsuite/gas/mips/micromips.s
index 6a0a4247446..ccf62f85c4e 100644
--- a/gas/testsuite/gas/mips/micromips.s
+++ b/gas/testsuite/gas/mips/micromips.s
@@ -5960,5 +5960,7 @@ test_spec107:
bltzal $2, test_spec107
nop
.endif
-
.end test_spec107
+
+# Force at least 8 (non-delay-slot) zero bytes, to make 'objdump' print ...
+ .space 8
diff --git a/gas/testsuite/gas/mips/micromipsr6@micromips.d b/gas/testsuite/gas/mips/micromipsr6@micromips.d
index f0d5f89da75..fb0755c280d 100644
--- a/gas/testsuite/gas/mips/micromipsr6@micromips.d
+++ b/gas/testsuite/gas/mips/micromipsr6@micromips.d
@@ -4484,6 +4484,5 @@ Disassembly of section .text:
[ ]*[0-9a-f]+: [ ]*47df movep a0,a3,s4,s2
[ ]*[0-9a-f]+: [ ]*47ef movep a0,a3,s4,s3
[ ]*[0-9a-f]+: [ ]*47ff movep a0,a3,s4,s4
-[ ]*[0-9a-f]+: [ ]*0c00 nop
-[ ]*[0-9a-f]+: [ ]*0000 0000 nop
+ \.\.\.
#pass
diff --git a/gas/testsuite/gas/mips/mips.exp b/gas/testsuite/gas/mips/mips.exp
index b48dc403baf..7568d225711 100644
--- a/gas/testsuite/gas/mips/mips.exp
+++ b/gas/testsuite/gas/mips/mips.exp
@@ -2223,7 +2223,9 @@ if { [istarget mips*-*-vxworks*] } {
run_dump_test_arches "llpscp-32" [mips_arch_list_matching mips32r6 !micromipsr6]
run_dump_test "llpscp-32-micromips"
run_dump_test_arch "llpscp-64" "" mips64r6
+ if $has_newabi {
run_dump_test "llpscp-64-micromips"
+ }
run_dump_test_arches "crypto" [mips_arch_list_matching mips32r6 \
!micromipsr6]
--
2.34.1
next prev parent reply other threads:[~2024-12-13 16:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 15:53 [PATCH 0/21] Integrate MIPS-Specific Support into Official binutils-gdb Milica Matic
2024-12-13 15:53 ` [PATCH 00/21] " Milica Matic
2024-12-13 15:53 ` [PATCH 01/21] Don't adjust microMIPS HI/LO rel section-relative Milica Matic
2024-12-13 15:53 ` [PATCH 02/21] Add new relocations for microMIPSR6 Milica Matic
2024-12-13 15:53 ` [PATCH 03/21] Improve WARN for $0 constraint on MIPSR6 branches Milica Matic
2024-12-13 15:53 ` [PATCH 04/21] Instruction mapping support (pre-R6 to R6) Milica Matic
2024-12-13 15:53 ` [PATCH 05/21] Add microMIPSR6 support Milica Matic
2024-12-13 15:53 ` [PATCH 06/21] Update branch relaxation Milica Matic
2024-12-13 15:53 ` [PATCH 07/21] Add --user-defined-sdata-sections Milica Matic
2024-12-13 15:53 ` [PATCH 08/21] Disassembler fix Milica Matic
2024-12-13 15:53 ` [PATCH 09/21] MIPS: Add CRYPTO ASE support Milica Matic
2024-12-13 15:53 ` [PATCH 10/21] Add the m6201 architecture Milica Matic
2024-12-13 15:53 ` [PATCH 11/21] Add GINV(+VIRT) ASE for MIPSr6/microMIPS6 Milica Matic
2024-12-13 15:53 ` [PATCH 12/21] Implement the XBurst MXU extensions Milica Matic
2024-12-13 15:53 ` [PATCH 13/21] MIPS: Update encoding of d16mule MXU instruction Milica Matic
2024-12-13 15:53 ` [PATCH 14/21] Re-arrange MXU code blocks and add comments Milica Matic
2024-12-13 15:53 ` [PATCH 15/21] Accept MCU mapped string operands as constants Milica Matic
2024-12-13 15:53 ` [PATCH 16/21] Fix addr2line mapping - garbage collected modules Milica Matic
2024-12-13 15:53 ` [PATCH 17/21] Extend trap macros to handle immediate zero Milica Matic
2024-12-13 15:53 ` Milica Matic [this message]
2024-12-13 15:53 ` [PATCH 19/21] Remove exec permission tc-mips.c Milica Matic
2024-12-13 15:53 ` [PATCH 20/21] Workaround for line info in compressed MIPS func Milica Matic
2024-12-13 15:53 ` [PATCH 21/21] Fix gold linker build issues for mingw Milica Matic
2025-01-07 21:18 ` [PATCH 0/21] Integrate MIPS-Specific Support into Official binutils-gdb Kevin Buettner
2025-01-09 1:11 ` [EXTERNAL]Re: " Chao-ying Fu
2025-01-07 21:31 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241213155328.406003-20-milica.matic@htecgroup.com \
--to=milicamatic05@gmail.com \
--cc=aburgess@redhat.com \
--cc=cfu@wavecomp.com \
--cc=djordje.todorovic@htecgroup.com \
--cc=fshahbazker@wavecomp.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=macro@orcam.me.uk \
--cc=milica.matic@htecgroup.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox