From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: pedro@palves.net, Kevin Buettner <kevinb@redhat.com>
Subject: [PATCH v5 2/4] Capitalize output of successful checkpoint command
Date: Mon, 9 Dec 2024 18:54:05 -0700 [thread overview]
Message-ID: <20241210020313.584564-3-kevinb@redhat.com> (raw)
In-Reply-To: <20241210020313.584564-1-kevinb@redhat.com>
This commit causes the output of a "checkpoint" command to be
changed from:
checkpoint N: fork returned pid DDDD
to:
Checkpoint N: fork returned pid DDDD
This change was made to bring the output of the "checkpoint" command in
line with that of other commands, e.g.:
(gdb) break main
Breakpoint 1 at ...
(gdb) catch exec
Catchpoint 2 (exec)
(gdb) add-inferior
[New inferior 2]
Added inferior 2
The tests gdb.base/checkpoint.exp, gdb.base/kill-during-detach.exp,
and gdb.multi/checkpoint-multi.exp have been updated to accept the new
(capitalized) output from the "checkpoint" command.
---
gdb/linux-fork.c | 2 +-
gdb/testsuite/gdb.base/checkpoint.exp | 2 +-
gdb/testsuite/gdb.base/kill-during-detach.exp | 2 +-
gdb/testsuite/gdb.multi/checkpoint-multi.exp | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gdb/linux-fork.c b/gdb/linux-fork.c
index 49c2cf1ed84..af7d4b60819 100644
--- a/gdb/linux-fork.c
+++ b/gdb/linux-fork.c
@@ -959,7 +959,7 @@ checkpoint_command (const char *args, int from_tty)
{
int parent_pid;
- gdb_printf (_("checkpoint %s: fork returned pid %ld.\n"),
+ gdb_printf (_("Checkpoint %s: fork returned pid %ld.\n"),
((number_of_inferiors () > 1)
? string_printf ("%d.%d", inf->num, fp->num).c_str ()
: string_printf ("%d", fp->num).c_str ()),
diff --git a/gdb/testsuite/gdb.base/checkpoint.exp b/gdb/testsuite/gdb.base/checkpoint.exp
index 4a8a9a8eb7f..68bddd8244d 100644
--- a/gdb/testsuite/gdb.base/checkpoint.exp
+++ b/gdb/testsuite/gdb.base/checkpoint.exp
@@ -359,7 +359,7 @@ with_test_prefix "delete checkpoint 0" {
clean_restart $binfile
runto_main
- gdb_test "checkpoint" "checkpoint 1: fork returned pid $decimal\\."
+ gdb_test "checkpoint" "Checkpoint 1: fork returned pid $decimal\\."
gdb_test "restart 1" "Switching to .*"
gdb_test "delete checkpoint 0" "Killed process $decimal"
gdb_test "info checkpoints" [string_to_regexp "No checkpoints."]
diff --git a/gdb/testsuite/gdb.base/kill-during-detach.exp b/gdb/testsuite/gdb.base/kill-during-detach.exp
index 68292cc3c51..d9ab8ee5383 100644
--- a/gdb/testsuite/gdb.base/kill-during-detach.exp
+++ b/gdb/testsuite/gdb.base/kill-during-detach.exp
@@ -93,7 +93,7 @@ proc run_test { exit_p checkpoint_p } {
# Set the checkpoint.
gdb_test "checkpoint" \
- "checkpoint 1: fork returned pid $::decimal\\."
+ "Checkpoint 1: fork returned pid $::decimal\\."
}
# Must get the PID before we resume the inferior.
diff --git a/gdb/testsuite/gdb.multi/checkpoint-multi.exp b/gdb/testsuite/gdb.multi/checkpoint-multi.exp
index 2bd654347b0..4860608e704 100644
--- a/gdb/testsuite/gdb.multi/checkpoint-multi.exp
+++ b/gdb/testsuite/gdb.multi/checkpoint-multi.exp
@@ -24,7 +24,7 @@ require gdb_protocol_is_native
set checkpoints_header_re " +Id +Active Target Id +Frame.*?"
set proc_re "(?:process $::decimal|Thread $::hex \\(LWP $::decimal\\))"
-set ckpt_re "checkpoint"
+set ckpt_re "Checkpoint"
set main_proc "\\(main process\\)"
set hello_c "hello\\.c"
set goodbye_c "goodbye\\.c"
--
2.46.2
next prev parent reply other threads:[~2024-12-10 2:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 1:54 [PATCH v5 0/4] Make linux checkpoints work with multiple inferiors Kevin Buettner
2024-12-10 1:54 ` [PATCH v5 1/4] " Kevin Buettner
2025-01-30 17:45 ` Andrew Burgess
2025-02-05 22:06 ` Kevin Buettner
2024-12-10 1:54 ` Kevin Buettner [this message]
2024-12-10 1:54 ` [PATCH v5 3/4] Print only process ptids from linux-fork.c Kevin Buettner
2024-12-10 1:54 ` [PATCH v5 4/4] Linux checkpoints: Update NEWS and gdb.texinfo regarding multiple inferiors Kevin Buettner
2024-12-10 13:04 ` Eli Zaretskii
2024-12-19 19:32 ` [PATCH v5 0/4] Make linux checkpoints work with " Tom Tromey
2025-01-30 17:46 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210020313.584564-3-kevinb@redhat.com \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox