Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org, pedro@palves.net
Subject: Re: [PATCH v5 4/4] Linux checkpoints: Update NEWS and gdb.texinfo regarding multiple inferiors
Date: Tue, 10 Dec 2024 15:04:15 +0200	[thread overview]
Message-ID: <86v7vrbsfk.fsf@gnu.org> (raw)
In-Reply-To: <20241210020313.584564-5-kevinb@redhat.com> (message from Kevin Buettner on Mon, 9 Dec 2024 18:54:07 -0700)

> From: Kevin Buettner <kevinb@redhat.com>
> Cc: pedro@palves.net,
> 	Kevin Buettner <kevinb@redhat.com>
> Date: Mon,  9 Dec 2024 18:54:07 -0700
> 
> ---
>  gdb/NEWS            |  2 ++
>  gdb/doc/gdb.texinfo | 20 +++++++++++++++++++-
>  2 files changed, 21 insertions(+), 1 deletion(-)

Thanks.

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -174,6 +174,8 @@ vFile:stat
>    vFile:fstat but takes a filename rather than an open file
>    descriptor.
>  
> +* Linux checkpoint code has been updated to work with multiple inferiors.
> +

This part is okay.

> +Checkpoint IDs will be displayed as either a non-negative integer or
> +in the form @var{I}.@var{N}, where @var{I} is the inferior number, a
> +positive integer, as shown by the command @code{info inferiors}, and
> +@var{N}, a non-negative integer, is the checkpoint number for that
> +inferior.  The single non-negative integer form is used when
> +there is only one inferior.  The @var{I}.@var{N} form is used when
> +there are multiple inferiors.

Please always use lower-case letters inside @var.  In Info format,
they are capitalized by makeinfo, but in other formats we get slanted
typeface which is much more pretty than upper-case.

> +The active state indicator is a single letter, either @code{y} or
> +@code{n}, indicating yes or no.  Only one checkpoint per inferior may
> +be active at once.  The active checkpoint in the current inferior is
> +also shown by a @code{*} at the start of the line.  Checkpoints whose
> +active state is @code{n} can be switched to

Please use @samp for the indicators, not @code.  These are not words,
so they will look strange without quotes in formats other than Info
(where makeinfo quotes them).

The gdb.texinfo part is okay with these nits fixed.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>

  reply	other threads:[~2024-12-10 13:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10  1:54 [PATCH v5 0/4] Make linux checkpoints work with " Kevin Buettner
2024-12-10  1:54 ` [PATCH v5 1/4] " Kevin Buettner
2025-01-30 17:45   ` Andrew Burgess
2025-02-05 22:06     ` Kevin Buettner
2024-12-10  1:54 ` [PATCH v5 2/4] Capitalize output of successful checkpoint command Kevin Buettner
2024-12-10  1:54 ` [PATCH v5 3/4] Print only process ptids from linux-fork.c Kevin Buettner
2024-12-10  1:54 ` [PATCH v5 4/4] Linux checkpoints: Update NEWS and gdb.texinfo regarding multiple inferiors Kevin Buettner
2024-12-10 13:04   ` Eli Zaretskii [this message]
2024-12-19 19:32 ` [PATCH v5 0/4] Make linux checkpoints work with " Tom Tromey
2025-01-30 17:46 ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86v7vrbsfk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox