From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kJlyMeyhV2en9wkAWB0awg (envelope-from ) for ; Mon, 09 Dec 2024 21:05:32 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Zv/UT6jx; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C82331E097; Mon, 9 Dec 2024 21:05:32 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7A34A1E05C for ; Mon, 9 Dec 2024 21:05:32 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ECC52385841C for ; Tue, 10 Dec 2024 02:05:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ECC52385841C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Zv/UT6jx Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id BDC243858D33 for ; Tue, 10 Dec 2024 02:03:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BDC243858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BDC243858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733796235; cv=none; b=vjsFPxWhq05/2ImlajLoI9VFDGNg0hA/sgw++6AtZUbkdkZ+v20B3xmu6Gvo5/koU0HVmW56lHQOctv+nzXkcNAt/bf3RyNIVDM/cBu2rVKSGBaR9TFuQLbi1oaM8XIbM4J4o/plgk6asxyg7RcOVrB4GWy8oP+DXa7/dIMIaUc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733796235; c=relaxed/simple; bh=JUo+qJ3LuVHO143Gftin1x9Wvt0nlA80YPG4k3HgMQ0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=qEJKJ15qzAt03ZQ2Nz07p7qfWGo3v1JnJAigGAgZvOUOxZ/ldLkBcGbIWQoHCGVF09pD8HwelIislmR+Sml5pJYoH5vslSCWqNPHHwc+AgC1H9nQUQRE36uEjXj7x97RkMMqXKVrMggt7ZPPjrw6FhGIwaNjZhnUocLGEFV1Y3c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BDC243858D33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733796235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AAc1kLPVytB/v/bdPKUN9aEqjAPRyTO62riA2jTE+tg=; b=Zv/UT6jxka43M/lr9xQKXKkN+FxYSpN2EzegBhuNfGK/8aXovP7fNpQqrwylWUvXmiYDRA Dg0b4hjf8+Yly8YzVngSGdT6QfHL1Csd/UoqoD12W/buNN/fvEEhBKbc+2lVkehU0oljOA g3YI5Jz2Cq+Hmo2ffdDfGLZE6YQyfk0= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-EKETTfyuOS2eHXDINFgoyA-1; Mon, 09 Dec 2024 21:03:52 -0500 X-MC-Unique: EKETTfyuOS2eHXDINFgoyA-1 X-Mimecast-MFC-AGG-ID: EKETTfyuOS2eHXDINFgoyA Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8AB3A1956095; Tue, 10 Dec 2024 02:03:51 +0000 (UTC) Received: from f41-1.lan (unknown [10.22.80.92]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 80BD11956089; Tue, 10 Dec 2024 02:03:50 +0000 (UTC) From: Kevin Buettner To: gdb-patches@sourceware.org Cc: pedro@palves.net, Kevin Buettner Subject: [PATCH v5 2/4] Capitalize output of successful checkpoint command Date: Mon, 9 Dec 2024 18:54:05 -0700 Message-ID: <20241210020313.584564-3-kevinb@redhat.com> In-Reply-To: <20241210020313.584564-1-kevinb@redhat.com> References: <20241210020313.584564-1-kevinb@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: G8NJV3aPSR3Y_MSvgPu-3MAv0tAQsr2XQp2COLZjzHM_1733796231 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This commit causes the output of a "checkpoint" command to be changed from: checkpoint N: fork returned pid DDDD to: Checkpoint N: fork returned pid DDDD This change was made to bring the output of the "checkpoint" command in line with that of other commands, e.g.: (gdb) break main Breakpoint 1 at ... (gdb) catch exec Catchpoint 2 (exec) (gdb) add-inferior [New inferior 2] Added inferior 2 The tests gdb.base/checkpoint.exp, gdb.base/kill-during-detach.exp, and gdb.multi/checkpoint-multi.exp have been updated to accept the new (capitalized) output from the "checkpoint" command. --- gdb/linux-fork.c | 2 +- gdb/testsuite/gdb.base/checkpoint.exp | 2 +- gdb/testsuite/gdb.base/kill-during-detach.exp | 2 +- gdb/testsuite/gdb.multi/checkpoint-multi.exp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/linux-fork.c b/gdb/linux-fork.c index 49c2cf1ed84..af7d4b60819 100644 --- a/gdb/linux-fork.c +++ b/gdb/linux-fork.c @@ -959,7 +959,7 @@ checkpoint_command (const char *args, int from_tty) { int parent_pid; - gdb_printf (_("checkpoint %s: fork returned pid %ld.\n"), + gdb_printf (_("Checkpoint %s: fork returned pid %ld.\n"), ((number_of_inferiors () > 1) ? string_printf ("%d.%d", inf->num, fp->num).c_str () : string_printf ("%d", fp->num).c_str ()), diff --git a/gdb/testsuite/gdb.base/checkpoint.exp b/gdb/testsuite/gdb.base/checkpoint.exp index 4a8a9a8eb7f..68bddd8244d 100644 --- a/gdb/testsuite/gdb.base/checkpoint.exp +++ b/gdb/testsuite/gdb.base/checkpoint.exp @@ -359,7 +359,7 @@ with_test_prefix "delete checkpoint 0" { clean_restart $binfile runto_main - gdb_test "checkpoint" "checkpoint 1: fork returned pid $decimal\\." + gdb_test "checkpoint" "Checkpoint 1: fork returned pid $decimal\\." gdb_test "restart 1" "Switching to .*" gdb_test "delete checkpoint 0" "Killed process $decimal" gdb_test "info checkpoints" [string_to_regexp "No checkpoints."] diff --git a/gdb/testsuite/gdb.base/kill-during-detach.exp b/gdb/testsuite/gdb.base/kill-during-detach.exp index 68292cc3c51..d9ab8ee5383 100644 --- a/gdb/testsuite/gdb.base/kill-during-detach.exp +++ b/gdb/testsuite/gdb.base/kill-during-detach.exp @@ -93,7 +93,7 @@ proc run_test { exit_p checkpoint_p } { # Set the checkpoint. gdb_test "checkpoint" \ - "checkpoint 1: fork returned pid $::decimal\\." + "Checkpoint 1: fork returned pid $::decimal\\." } # Must get the PID before we resume the inferior. diff --git a/gdb/testsuite/gdb.multi/checkpoint-multi.exp b/gdb/testsuite/gdb.multi/checkpoint-multi.exp index 2bd654347b0..4860608e704 100644 --- a/gdb/testsuite/gdb.multi/checkpoint-multi.exp +++ b/gdb/testsuite/gdb.multi/checkpoint-multi.exp @@ -24,7 +24,7 @@ require gdb_protocol_is_native set checkpoints_header_re " +Id +Active Target Id +Frame.*?" set proc_re "(?:process $::decimal|Thread $::hex \\(LWP $::decimal\\))" -set ckpt_re "checkpoint" +set ckpt_re "Checkpoint" set main_proc "\\(main process\\)" set hello_c "hello\\.c" set goodbye_c "goodbye\\.c" -- 2.46.2