From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv2] gdb/build-id: protect against weirdly short build-ids
Date: Thu, 21 Nov 2024 09:05:08 -0700 [thread overview]
Message-ID: <20241121090508.554328c8@f40-zbm-amd> (raw)
In-Reply-To: <b65fae2a6ed0d037756485d82697d56be31d1674.1732199210.git.aburgess@redhat.com>
On Thu, 21 Nov 2024 14:29:05 +0000
Andrew Burgess <aburgess@redhat.com> wrote:
> In v2:
>
> - Print a debug message when a short build-id is ignored. I did
> consider a warning, but I wasn't sure if that was suitable or not.
> In the end some debug output means we can at least diagnose why
> the debug lookup failed.
I think this is fine. I've worked on bugs in the past where GDB was
spamming the user with hundreds (or thousands...) of warnings. If
we were to output a warning for this case, I think it'd be important
to make sure that it doesn't happen more than a few times per session.
In any case, I'm happy to see that you've provided a way to diagnose
the problem.
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2024-11-21 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 10:00 [PATCH] " Andrew Burgess
2024-11-20 21:22 ` Kevin Buettner
2024-11-21 14:30 ` Andrew Burgess
2024-11-21 14:29 ` [PATCHv2] " Andrew Burgess
2024-11-21 16:05 ` Kevin Buettner [this message]
2024-11-21 19:39 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241121090508.554328c8@f40-zbm-amd \
--to=kevinb@redhat.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox