From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XgDcBWtaP2e5kTkAWB0awg (envelope-from ) for ; Thu, 21 Nov 2024 11:06:03 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=J5OPmoKc; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id ED3C71E259; Thu, 21 Nov 2024 11:06:02 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 86EF31E1CC for ; Thu, 21 Nov 2024 11:06:01 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AF84F3857357 for ; Thu, 21 Nov 2024 16:06:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AF84F3857357 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=J5OPmoKc Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 86F6E3858280 for ; Thu, 21 Nov 2024 16:05:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 86F6E3858280 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 86F6E3858280 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732205120; cv=none; b=kqR2gPdqUe2N5Wht3ASgBREO8rcsndXY179HkzOdMnVOMuH5r1MY0DiUy/OMTsM7lIRg9Rkq1kJgZ0jdOOxkVOtFpug3RbwbWS5G0ansjQ1DcJAnt8jOFjd4boBeMD5o/f3DLgnKjG6qBHEFAli17RMd1YBYx8qJ/D51wnf+NYc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732205120; c=relaxed/simple; bh=85jSeUlucXpKZSyI17gNYnixVKoXzvLmhIIOdxNNWo0=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=BcjkxOgP7sV1PEVoatJLYE7KwbqZuJEZ/o0FzrTfiempR+fR/HdkPmq5BieER0c4yst5QwTtlfwzKGmFXbVGxB5YZhkOkX40mxfu1FFAHMHowueHcSoQ/g7bVPFntm1g9zNGSLDnDdIfQo0Oh9MnzV5uDm6BJqqc71LksS6t1ZE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 86F6E3858280 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732205120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i6I6a52XE7CieNZIkJQhjH07d5w5Ebh9ZGvZ4NsKCAA=; b=J5OPmoKc3TN20cY7fmAIWB91/vOh80FdGYgn/lAt6YfNlDo+HQ/6EAZiatPjSWxvlvACUQ AP0SUupwo2EGV/km6ER0Z5HWYvVPfT2lWmKrnZQ+6AcaHMALX6v4/i332PTjPGJ1iKrjmv KmncdwTfGGR4l04VeITyxZVceoc2o/I= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-IyHMtC70M8i5k3qClUQ3Sg-1; Thu, 21 Nov 2024 11:05:16 -0500 X-MC-Unique: IyHMtC70M8i5k3qClUQ3Sg-1 X-Mimecast-MFC-AGG-ID: IyHMtC70M8i5k3qClUQ3Sg Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 479721955EA7 for ; Thu, 21 Nov 2024 16:05:15 +0000 (UTC) Received: from f40-zbm-amd (unknown [10.22.80.92]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 706AD1955F3E; Thu, 21 Nov 2024 16:05:14 +0000 (UTC) Date: Thu, 21 Nov 2024 09:05:08 -0700 From: Kevin Buettner To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2] gdb/build-id: protect against weirdly short build-ids Message-ID: <20241121090508.554328c8@f40-zbm-amd> In-Reply-To: References: Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: evSGzPJJJ9rNdO2Cgl-p1aSDdjjzMB_bQPpqW_OPkAk_1732205115 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thu, 21 Nov 2024 14:29:05 +0000 Andrew Burgess wrote: > In v2: > > - Print a debug message when a short build-id is ignored. I did > consider a warning, but I wasn't sure if that was suitable or not. > In the end some debug output means we can at least diagnose why > the debug lookup failed. I think this is fine. I've worked on bugs in the past where GDB was spamming the user with hundreds (or thousands...) of warnings. If we were to output a warning for this case, I think it'd be important to make sure that it doesn't happen more than a few times per session. In any case, I'm happy to see that you've provided a way to diagnose the problem. Approved-by: Kevin Buettner