From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/build-id: protect against weirdly short build-ids
Date: Wed, 20 Nov 2024 14:22:24 -0700 [thread overview]
Message-ID: <20241120142224.6e54aa4c@f40-zbm-amd> (raw)
In-Reply-To: <ba559099b3deffb790d1c4c500d17c543eb0b930.1732010413.git.aburgess@redhat.com>
On Tue, 19 Nov 2024 10:00:28 +0000
Andrew Burgess <aburgess@redhat.com> wrote:
> I propose that, in build_id_to_bfd_suffix we just return early if the
> build-id is 1 byte (or less) with a return value that indicates no
> separate file was found.
I wonder if also printing some sort of warning might be appropriate in
such cases? If a general warning isn't suitable, I think it makes
sense to at least use separate_debug_file_debug_printf() to output
a suitable message when separate-debug-file debugging is enabled.
Kevin
next prev parent reply other threads:[~2024-11-20 21:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 10:00 Andrew Burgess
2024-11-20 21:22 ` Kevin Buettner [this message]
2024-11-21 14:30 ` Andrew Burgess
2024-11-21 14:29 ` [PATCHv2] " Andrew Burgess
2024-11-21 16:05 ` Kevin Buettner
2024-11-21 19:39 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241120142224.6e54aa4c@f40-zbm-amd \
--to=kevinb@redhat.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox