From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +74FMDhTPmfagzgAWB0awg (envelope-from ) for ; Wed, 20 Nov 2024 16:23:04 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RHjJINko; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9833E1E253; Wed, 20 Nov 2024 16:23:04 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 014121E1CC for ; Wed, 20 Nov 2024 16:23:03 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 82ED53858282 for ; Wed, 20 Nov 2024 21:23:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 82ED53858282 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RHjJINko Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id AC4313858D26 for ; Wed, 20 Nov 2024 21:22:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AC4313858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AC4313858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732137752; cv=none; b=IYmIBqUwNO34LMybnevljfzSH/ABmfCg0utI6Z82mHYpmg2vNRir1OX0O0ruc+X6xubEM1jJnhNKxwyg5+/yJ1BJ7Rpn9n+JTdmaCCHqVQfeoKHYouD3wuz8NpgNLoGCrTX+DcAzYxGUs7Wa//ynx5oSPmGkcBO4JZ4TtKosSig= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732137752; c=relaxed/simple; bh=g3ssUj9CUYv4Cf5AGHigx7qev5ml9BETLG6asMw5Rcc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=MdaXAF0QVtZdkuo+vBTBMQArO2ZZi/g6xx7PJoIYcB/7UkWZbQQZEZMXHGuWw/bMktTH2LUq1vDoA/gf90TllfEmFO1qmCdWNjeAC8S9qBExM7401PnMeTlmFpnvok3uijcbkJR6aJmmrP3OUld6vy76u248FGpwuvbtLVaCSwU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AC4313858D26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732137752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ysal0JrREW7eJ3bRN3aRyVwq5DGEOOMM6RxQHn6QfGE=; b=RHjJINko5BTfnklmEzDaNkX8JNnXJ16HzkjY8Iy3Q1fmM7Oa97NApX0MClS9+uloi60hEZ lYtUR/IdDkXjLp5PP7wXsTcNWhoFdHe/DXScDdEO8b2MQ7tGLJ15PZ18/TQl7sU9XQQK+g D6ERQPY8c9JtULnj2lUKuT+RiuPXGcQ= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-7-FKYCLyGeNjWGL1QgltkAPA-1; Wed, 20 Nov 2024 16:22:31 -0500 X-MC-Unique: FKYCLyGeNjWGL1QgltkAPA-1 X-Mimecast-MFC-AGG-ID: FKYCLyGeNjWGL1QgltkAPA Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 714031956088 for ; Wed, 20 Nov 2024 21:22:30 +0000 (UTC) Received: from f40-zbm-amd (unknown [10.22.80.92]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9192A19560A3; Wed, 20 Nov 2024 21:22:29 +0000 (UTC) Date: Wed, 20 Nov 2024 14:22:24 -0700 From: Kevin Buettner To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/build-id: protect against weirdly short build-ids Message-ID: <20241120142224.6e54aa4c@f40-zbm-amd> In-Reply-To: References: Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dcU-rmz6rqW_Jv773mYCtK0XB7yOMbjicPVH0S7uANo_1732137750 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tue, 19 Nov 2024 10:00:28 +0000 Andrew Burgess wrote: > I propose that, in build_id_to_bfd_suffix we just return early if the > build-id is 1 byte (or less) with a return value that indicates no > separate file was found. I wonder if also printing some sort of warning might be appropriate in such cases? If a general warning isn't suitable, I think it makes sense to at least use separate_debug_file_debug_printf() to output a suitable message when separate-debug-file debugging is enabled. Kevin