From: Dmitry Neverov <dmitry.neverov@jetbrains.com>
To: gdb-patches@sourceware.org
Cc: dmitry.neverov@jetbrains.com
Subject: [RFC v2][PR symtab/30520 3/4] gdb/symtab: compute match_type outside the loop
Date: Tue, 23 Jan 2024 18:03:24 +0100 [thread overview]
Message-ID: <20240123170325.752251-3-dmitry.neverov@jetbrains.com> (raw)
In-Reply-To: <20240123170325.752251-1-dmitry.neverov@jetbrains.com>
It will be used for all segments in a qualified name,
not only the last one.
---
gdb/dwarf2/read.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index f539eb878a3..338e2bfbfa7 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -16632,6 +16632,9 @@ cooked_index_functions::expand_symtabs_matching
language_ada
};
+ symbol_name_match_type match_type
+ = lookup_name_without_params.match_type ();
+
for (enum language lang : unique_styles)
{
std::vector<std::string_view> name_vec
@@ -16689,8 +16692,6 @@ cooked_index_functions::expand_symtabs_matching
"x::a::b". */
if (symbol_matcher == nullptr)
{
- symbol_name_match_type match_type
- = lookup_name_without_params.match_type ();
if ((match_type == symbol_name_match_type::FULL
|| (lang != language_ada
&& match_type == symbol_name_match_type::EXPRESSION)))
--
2.39.2
next prev parent reply other threads:[~2024-01-23 17:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 17:03 [RFC v2][PR symtab/30520 1/4] gdb/symtab: check name matches before expanding a CU Dmitry Neverov
2024-01-23 17:03 ` [RFC v2][PR symtab/30520 2/4] gdb/symtab: reuse last segment lookup name info Dmitry Neverov
2024-01-23 17:03 ` Dmitry Neverov [this message]
2024-01-23 17:03 ` [RFC v2][PR symtab/30520 4/4] gdb/symtab: use symbol name matcher for all segments in a qualified name Dmitry Neverov
2024-01-25 8:44 ` [RFC v2][PR symtab/30520] gdb/symtab: fix the gdb.cp/anon-struct test Dmitry Neverov
2024-02-07 20:25 ` Tom Tromey
2024-02-09 16:32 ` Dmitry Neverov
2024-02-09 19:38 ` Tom Tromey
2024-03-18 16:35 ` Dmitry Neverov
2024-03-18 17:58 ` Tom Tromey
2024-03-19 12:16 ` Dmitry Neverov
2024-03-22 17:29 ` Tom Tromey
2024-05-04 1:20 ` Joel Brobecker
2024-05-06 14:32 ` Dmitry Neverov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123170325.752251-3-dmitry.neverov@jetbrains.com \
--to=dmitry.neverov@jetbrains.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox