From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SCQJEqzxr2U6dAUAWB0awg (envelope-from ) for ; Tue, 23 Jan 2024 12:04:44 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=jetbrains.com header.i=@jetbrains.com header.a=rsa-sha256 header.s=googleapps header.b=J6R/PGtc; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 46E861E0C3; Tue, 23 Jan 2024 12:04:44 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3911D1E092 for ; Tue, 23 Jan 2024 12:04:42 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AE4D438582B4 for ; Tue, 23 Jan 2024 17:04:41 +0000 (GMT) Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 671E13858C2F for ; Tue, 23 Jan 2024 17:03:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 671E13858C2F Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=jetbrains.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jetbrains.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 671E13858C2F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::534 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706029428; cv=none; b=eXAVIcxqL7BacluBgHa+Ew46jZAwYHXstud6DnddzdQKlNJlMP3FAFQ2mNtm6zdKtDQizQPb/at1pZjah5tQ16WIGsNwMb4IluKQB8O+atXbQA2G+qwRJdBErCCSJkdWCSd9qpKKMI3xtjaRje4r/bssTgx5Qjyz+VDasiGsbFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706029428; c=relaxed/simple; bh=4ZD8WxGztLjbZpTodUGqDTy6yTE+prbHGm2Fs1DfOUo=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=Ks1ox8aau2sEdgTDIVwo+zyd0SMFDcXlzNFDq7c7XfVKBfzfTV0JXio1IO/mZhMMs8R95hyCBZ8gugFrMFeIj6XhFaW7wVq78zKNtatKitTlAuUl1SGxTQqDDmbOU1Jg7d8+YKirqxO2I+n2sQaYbBT8wJdZ7pwNdM57S9oW4Ks= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-557dcb0f870so5400158a12.2 for ; Tue, 23 Jan 2024 09:03:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jetbrains.com; s=googleapps; t=1706029414; x=1706634214; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Da+qopKB7EYOoXuYSll0O4LssqfjvwoLKZwTOUEwskY=; b=J6R/PGtcOban6RsHM//xG/OotJzhO9qVGbujk3Af9EnfjgfO7Z2TZmH7ODAAhm/IvT a3azhTLnZKQW9e06+jFetpBS+zm5GbhR16Jbk+2kTyK9oX46BzwT0oB2SXT5ZcXiFgGb ydObPSfSWl48/s4jfJRuC+DJ1oBeZwMDKHF4k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706029414; x=1706634214; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Da+qopKB7EYOoXuYSll0O4LssqfjvwoLKZwTOUEwskY=; b=R7/zYsbpiizTnHjBwjNb3W72zGLmapGm8/kL2k6jEmEv8neprIKZND4rqQZAKn+9Nc RVXqZ5RjH/tQpL2ihfzwewYkN5aWgEPySI1Up8HemKUMce978g3Nk3b/raU660Xe5d+n mgSslMVii8fCTmIQj9wTCfE5NoEAEQpXRf8dTKb9yG4SZctq3HdRDmDoC8/j1BAOdE2s daXS+slIxRA60v4PuWSJOQUnrCbHpX11F65gDDTTczsnrFpe/vivD0Ru2Qt2R3R5Lj4Q saaATq9fhxOTnnqkVgV+RJheE7vwAUFiD5pVDOK4q2NZbxdxiaWbebpiy/+r/2VIEW0Q Jplw== X-Gm-Message-State: AOJu0YxzQqwsFuQbWvOcZHPBSKJqJc25ZbcdM3JYai7f1Y5kDTt3SZsl iQuh9yke/6Kw9qCymKGY9K2AvQ0G0D10bxxSTBahJXxzXlLCSFqHzOjMNXyDWUU1iEg74dwwerr SNA== X-Google-Smtp-Source: AGHT+IHdtMlMaTPVJzgeHKzOcaAkx8HzVEHsjNP+507KHEK7WheQUkb/uiRVXJmat/kQrvAFeP74iA== X-Received: by 2002:a17:906:f949:b0:a27:cf29:5380 with SMTP id ld9-20020a170906f94900b00a27cf295380mr73886ejb.149.1706029413983; Tue, 23 Jan 2024 09:03:33 -0800 (PST) Received: from nd-lubuntu.labs.intellij.net (ad96e1c12.dsl.de.colt.net. [217.110.28.18]) by smtp.gmail.com with ESMTPSA id p26-20020a1709061b5a00b00a298ade2e72sm14569741ejg.195.2024.01.23.09.03.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 09:03:33 -0800 (PST) From: Dmitry Neverov To: gdb-patches@sourceware.org Cc: dmitry.neverov@jetbrains.com Subject: [RFC v2][PR symtab/30520 3/4] gdb/symtab: compute match_type outside the loop Date: Tue, 23 Jan 2024 18:03:24 +0100 Message-Id: <20240123170325.752251-3-dmitry.neverov@jetbrains.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240123170325.752251-1-dmitry.neverov@jetbrains.com> References: <20240123170325.752251-1-dmitry.neverov@jetbrains.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org It will be used for all segments in a qualified name, not only the last one. --- gdb/dwarf2/read.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index f539eb878a3..338e2bfbfa7 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -16632,6 +16632,9 @@ cooked_index_functions::expand_symtabs_matching language_ada }; + symbol_name_match_type match_type + = lookup_name_without_params.match_type (); + for (enum language lang : unique_styles) { std::vector name_vec @@ -16689,8 +16692,6 @@ cooked_index_functions::expand_symtabs_matching "x::a::b". */ if (symbol_matcher == nullptr) { - symbol_name_match_type match_type - = lookup_name_without_params.match_type (); if ((match_type == symbol_name_match_type::FULL || (lang != language_ada && match_type == symbol_name_match_type::EXPRESSION))) -- 2.39.2