From: Dmitry Neverov <dmitry.neverov@jetbrains.com>
To: gdb-patches@sourceware.org
Cc: dmitry.neverov@jetbrains.com
Subject: [RFC v2][PR symtab/30520] gdb/symtab: fix the gdb.cp/anon-struct test
Date: Thu, 25 Jan 2024 09:44:04 +0100 [thread overview]
Message-ID: <20240125084404.3536456-1-dmitry.neverov@jetbrains.com> (raw)
In-Reply-To: <20240123170325.752251-1-dmitry.neverov@jetbrains.com>
The symbol_name_match_type::SEARCH_NAME cannot be used because
demangle_for_lookup_info doesn't initialize a demangled name
for it which makes a subsequent name matching to fail.
---
gdb/dwarf2/read.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 08a834e141b..3f1d2e9a813 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -16644,7 +16644,7 @@ cooked_index_functions::expand_symtabs_matching
segment_lookup_names.reserve (name_vec.size ());
for (auto &segment_name : name_str_vec) {
segment_lookup_names.emplace_back (
- segment_name, symbol_name_match_type::SEARCH_NAME, completing, true);
+ segment_name, symbol_name_match_type::FULL, completing, true);
}
for (const cooked_index_entry *entry : table->find (name_str_vec.back (),
--
2.39.2
next prev parent reply other threads:[~2024-01-25 8:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 17:03 [RFC v2][PR symtab/30520 1/4] gdb/symtab: check name matches before expanding a CU Dmitry Neverov
2024-01-23 17:03 ` [RFC v2][PR symtab/30520 2/4] gdb/symtab: reuse last segment lookup name info Dmitry Neverov
2024-01-23 17:03 ` [RFC v2][PR symtab/30520 3/4] gdb/symtab: compute match_type outside the loop Dmitry Neverov
2024-01-23 17:03 ` [RFC v2][PR symtab/30520 4/4] gdb/symtab: use symbol name matcher for all segments in a qualified name Dmitry Neverov
2024-01-25 8:44 ` Dmitry Neverov [this message]
2024-02-07 20:25 ` [RFC v2][PR symtab/30520] gdb/symtab: fix the gdb.cp/anon-struct test Tom Tromey
2024-02-09 16:32 ` Dmitry Neverov
2024-02-09 19:38 ` Tom Tromey
2024-03-18 16:35 ` Dmitry Neverov
2024-03-18 17:58 ` Tom Tromey
2024-03-19 12:16 ` Dmitry Neverov
2024-03-22 17:29 ` Tom Tromey
2024-05-04 1:20 ` Joel Brobecker
2024-05-06 14:32 ` Dmitry Neverov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125084404.3536456-1-dmitry.neverov@jetbrains.com \
--to=dmitry.neverov@jetbrains.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox