GDB 11.0.90 available for testing

GDB 11.0.90 available for testing

[Joel Brobecker]

Hello,

I have just finished creating the gdb-11.0.90 pre-release.
It is available for download at the following location:

    ftp://sourceware.org/pub/gdb/snapshots/branch/gdb-11.0.90.tar.xz

A gzip'ed version is also available: gdb-11.0.90.tar.gz.

Please give it a test if you can and report any problems you might find.

On behalf of all the GDB contributors, thank you!
-- 
Joel Brobecker

Re: GDB 11.0.90 available for testing

[Eli Zaretskii via Gdb-patches]

> From: Joel Brobecker <brobecker@adacore.com>
> Date: Sat,  3 Jul 2021 11:48:33 -0700 (PDT)
> 
> Hello,
> 
> I have just finished creating the gdb-11.0.90 pre-release.
> It is available for download at the following location:
> 
>     ftp://sourceware.org/pub/gdb/snapshots/branch/gdb-11.0.90.tar.xz
> 
> A gzip'ed version is also available: gdb-11.0.90.tar.gz.
> 
> Please give it a test if you can and report any problems you might find.

This builds successfully, with minor problems, on native MS-Windows
using mingw.org's MinGW.  The minor problems I found are:

1. A compilation warning in Gnulib's select.c -- reported to the
Gnulib folks.

2. A compilation warning in symtab.c:

       CXX    symtab.o
     symtab.c: In member function 'bool info_sources_filter::matches(const char*) const':
     symtab.c:4247:28: warning: 'to_match' may be used uninitialized in this function [-Wmaybe-uninitialized]
      4247 |       if (m_c_regexp->exec (to_match, 0, NULL, 0) != 0)
	   |           ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~

I guess we need a 'default:' case there?  Or maybe initialize
'to_match' with some suitable value?

Thanks.

Re: GDB 11.0.90 available for testing

[Simon Marchi via Gdb-patches]

On 2021-07-08 12:39 p.m., Eli Zaretskii via Gdb-patches wrote:
>> From: Joel Brobecker <brobecker@adacore.com>
>> Date: Sat,  3 Jul 2021 11:48:33 -0700 (PDT)
>>
>> Hello,
>>
>> I have just finished creating the gdb-11.0.90 pre-release.
>> It is available for download at the following location:
>>
>>     ftp://sourceware.org/pub/gdb/snapshots/branch/gdb-11.0.90.tar.xz
>>
>> A gzip'ed version is also available: gdb-11.0.90.tar.gz.
>>
>> Please give it a test if you can and report any problems you might find.
> 
> This builds successfully, with minor problems, on native MS-Windows
> using mingw.org's MinGW.  The minor problems I found are:
> 
> 1. A compilation warning in Gnulib's select.c -- reported to the
> Gnulib folks.
> 
> 2. A compilation warning in symtab.c:
> 
>        CXX    symtab.o
>      symtab.c: In member function 'bool info_sources_filter::matches(const char*) const':
>      symtab.c:4247:28: warning: 'to_match' may be used uninitialized in this function [-Wmaybe-uninitialized]
>       4247 |       if (m_c_regexp->exec (to_match, 0, NULL, 0) != 0)
> 	   |           ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
> 
> I guess we need a 'default:' case there?  Or maybe initialize
> 'to_match' with some suitable value?

See:

https://sourceware.org/pipermail/gdb-patches/2021-July/180689.html

So it would be worth pushing that patch to the release branch.

Simon

Re: GDB 11.0.90 available for testing

[Eli Zaretskii via Gdb-patches]

> Cc: gdb-patches@sourceware.org
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Date: Thu, 8 Jul 2021 12:56:25 -0400
> 
> >        CXX    symtab.o
> >      symtab.c: In member function 'bool info_sources_filter::matches(const char*) const':
> >      symtab.c:4247:28: warning: 'to_match' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >       4247 |       if (m_c_regexp->exec (to_match, 0, NULL, 0) != 0)
> > 	   |           ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
> > 
> > I guess we need a 'default:' case there?  Or maybe initialize
> > 'to_match' with some suitable value?
> 
> See:
> 
> https://sourceware.org/pipermail/gdb-patches/2021-July/180689.html
> 
> So it would be worth pushing that patch to the release branch.

Yes, I agree.

Re: GDB 11.0.90 available for testing

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

> > 1. A compilation warning in Gnulib's select.c -- reported to the
> > Gnulib folks.
> > 
> > 2. A compilation warning in symtab.c:
> > 
> >        CXX    symtab.o
> >      symtab.c: In member function 'bool info_sources_filter::matches(const char*) const':
> >      symtab.c:4247:28: warning: 'to_match' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >       4247 |       if (m_c_regexp->exec (to_match, 0, NULL, 0) != 0)
> > 	   |           ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
> > 
> > I guess we need a 'default:' case there?  Or maybe initialize
> > 'to_match' with some suitable value?
> 
> See:
> 
> https://sourceware.org/pipermail/gdb-patches/2021-July/180689.html
> 
> So it would be worth pushing that patch to the release branch.

Thanks for pointing towards the patch, Simon.

Patch pushed to the gdb-11-branch.

-- 
Joel

[-- Attachment #2: 0001-Fix-warning-in-symtab.c.patch --]
[-- Type: text/x-diff, Size: 1595 bytes --]

From 2814ff838841c24a71b5cfbb982785fc95d424f8 Mon Sep 17 00:00:00 2001
From: Tom Tromey <tom@tromey.com>
Date: Sun, 11 Jul 2021 06:59:33 -0700
Subject: [PATCH] Fix warning in symtab.c

The compiler gives this warning when building symtab.c:

../../binutils-gdb/gdb/symtab.c:4247:28: warning: 'to_match' may be used uninitialized in this function [-Wmaybe-uninitialized]

This patch fixes the warning by adding a gdb_assert_not_reached.

gdb/ChangeLog:

        * gdb/symtab.c (info_sources_filter::matches): Add default
        case hander in switch statement.

(cherry picked from commit b6aeb717a8bdaa9cc348ec88a5fdf059e1337580)
---
 gdb/ChangeLog | 6 ++++++
 gdb/symtab.c  | 2 ++
 2 files changed, 8 insertions(+)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f37f61de030..087796b8b19 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2021-07-11  Tom Tromey  <tom@tromey.com>
+
+	Committed by Joel Brobecker  <brobecker@adacore.com>:
+	* gdb/symtab.c (info_sources_filter::matches): Add default
+	case hander in switch statement.
+
 2021-07-08  Simon Marchi  <simon.marchi@polymtl.ca>
 
 	* s390-linux-tdep.c (s390_linux_init_abi_any): Pass 1 (number
diff --git a/gdb/symtab.c b/gdb/symtab.c
index 6a9c3dce6af..fa3f42207ec 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -4242,6 +4242,8 @@ info_sources_filter::matches (const char *fullname) const
         case match_on::FULLNAME:
           to_match = fullname;
           break;
+	default:
+	  gdb_assert_not_reached ("bad m_match_type");
         }
 
       if (m_c_regexp->exec (to_match, 0, NULL, 0) != 0)
-- 
2.25.1