From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EdJMDdL56mDjUAAAWB0awg (envelope-from ) for ; Sun, 11 Jul 2021 10:01:54 -0400 Received: by simark.ca (Postfix, from userid 112) id 27FFE1EDEA; Sun, 11 Jul 2021 10:01:54 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7EE201EDDB for ; Sun, 11 Jul 2021 10:01:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 454423861C5E for ; Sun, 11 Jul 2021 14:01:49 +0000 (GMT) Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id A7AE73854833 for ; Sun, 11 Jul 2021 14:01:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A7AE73854833 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-pj1-x1035.google.com with SMTP id n11so8508925pjo.1 for ; Sun, 11 Jul 2021 07:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GAdqLcOHHyicVdORPG6yxU0QlyqQHI8ivwjcRHRyujY=; b=UDKDyHKpa13Lt2fH1uGMj7+75TIaqCh1W5U5bLND1aH33dM2z4rvKsAv6gIS0RhYiA Y9tXj0FwL6JCEVng63ImNMf+HXKgcmdRrluv9mkaA+s9MBbOF5AvLGuIpxLlLZSmQzUH QFAYYT+Bo1in8anlT4KxIFf5bt1TevsSnYsfXhX5oEweTkqR0f0rWo2W71IPOHLMlGFe ev+6TfdI4MkpNK8e6brAuMjMCwPSg07Q0uRx88uXlGTh4cR+IKZWENCthKDn9CKj6kmv cnBY02oyeuI/xe3YSjyrtIdJaLxfYt38xCoNKMKALKuYGKWJkUUjFY9uw/tbqlqL4yDv mG7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GAdqLcOHHyicVdORPG6yxU0QlyqQHI8ivwjcRHRyujY=; b=U9Dj9mQGJt1Agc6GVa4Sq74ZRIITAATRBKxUO5DpbJ2upTYTzlVjycHUI4ROHp28dZ 73ieWIthcIFs1CgoeqNcmVQA+d9uQ/axLruPqIP2k5+ebgXKDv4GeR1hF7hiF+2zkdNO ccHvwsC0EbGyrqVT0ECnhPnyH8DRL8M8lMsk3htJ2iIq00fXVjr6V2ovtgngL+gWbBwN ef9rJqFx9AENezaDekSr4AoZquS9ohelN+4/zdDVLpFo90KTEsMrPhp9gVqkiRLwAq3y X0XppQrH8KgXf6aQQng3uBMpXEOhFYlOQv12VXn1goRG1uR7DsW/iMFijWJoB7MQo/1g M9Rg== X-Gm-Message-State: AOAM532gf5ZiePSU1dWnqktL6IBjeJqfLo43DvE0O0Ple5CuFs8Gr4B3 VuuNTVSUkBhzWDsd8wmYLEzdK9Z6itXl X-Google-Smtp-Source: ABdhPJx61gMUG6ZTQZkPpiaNqMBxur2X0xl/QOo3/bfafSOlSgufweIbQlevvYW46OHUUgqE4VVt9w== X-Received: by 2002:a17:90a:d486:: with SMTP id s6mr19755207pju.142.1626012096827; Sun, 11 Jul 2021 07:01:36 -0700 (PDT) Received: from takamaka.home ([184.69.131.86]) by smtp.gmail.com with ESMTPSA id f18sm17743884pjq.48.2021.07.11.07.01.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jul 2021 07:01:35 -0700 (PDT) Received: by takamaka.home (Postfix, from userid 1000) id B231B89CFD; Sun, 11 Jul 2021 07:01:34 -0700 (PDT) Date: Sun, 11 Jul 2021 07:01:34 -0700 From: Joel Brobecker To: Simon Marchi Subject: Re: GDB 11.0.90 available for testing Message-ID: <20210711140134.GA634772@adacore.com> References: <20210703184833.94F2889AFF@takamaka.home> <83zguwdajv.fsf@gnu.org> <5f0c8991-fbcc-1cf9-119f-3b4195f32bea@polymtl.ca> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="J2SCkAp4GZ/dPZZf" Content-Disposition: inline In-Reply-To: <5f0c8991-fbcc-1cf9-119f-3b4195f32bea@polymtl.ca> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org, Joel Brobecker Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > > 1. A compilation warning in Gnulib's select.c -- reported to the > > Gnulib folks. > > > > 2. A compilation warning in symtab.c: > > > > CXX symtab.o > > symtab.c: In member function 'bool info_sources_filter::matches(const char*) const': > > symtab.c:4247:28: warning: 'to_match' may be used uninitialized in this function [-Wmaybe-uninitialized] > > 4247 | if (m_c_regexp->exec (to_match, 0, NULL, 0) != 0) > > | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ > > > > I guess we need a 'default:' case there? Or maybe initialize > > 'to_match' with some suitable value? > > See: > > https://sourceware.org/pipermail/gdb-patches/2021-July/180689.html > > So it would be worth pushing that patch to the release branch. Thanks for pointing towards the patch, Simon. Patch pushed to the gdb-11-branch. -- Joel --J2SCkAp4GZ/dPZZf Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Fix-warning-in-symtab.c.patch" >From 2814ff838841c24a71b5cfbb982785fc95d424f8 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sun, 11 Jul 2021 06:59:33 -0700 Subject: [PATCH] Fix warning in symtab.c The compiler gives this warning when building symtab.c: ../../binutils-gdb/gdb/symtab.c:4247:28: warning: 'to_match' may be used uninitialized in this function [-Wmaybe-uninitialized] This patch fixes the warning by adding a gdb_assert_not_reached. gdb/ChangeLog: * gdb/symtab.c (info_sources_filter::matches): Add default case hander in switch statement. (cherry picked from commit b6aeb717a8bdaa9cc348ec88a5fdf059e1337580) --- gdb/ChangeLog | 6 ++++++ gdb/symtab.c | 2 ++ 2 files changed, 8 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index f37f61de030..087796b8b19 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2021-07-11 Tom Tromey + + Committed by Joel Brobecker : + * gdb/symtab.c (info_sources_filter::matches): Add default + case hander in switch statement. + 2021-07-08 Simon Marchi * s390-linux-tdep.c (s390_linux_init_abi_any): Pass 1 (number diff --git a/gdb/symtab.c b/gdb/symtab.c index 6a9c3dce6af..fa3f42207ec 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -4242,6 +4242,8 @@ info_sources_filter::matches (const char *fullname) const case match_on::FULLNAME: to_match = fullname; break; + default: + gdb_assert_not_reached ("bad m_match_type"); } if (m_c_regexp->exec (to_match, 0, NULL, 0) != 0) -- 2.25.1 --J2SCkAp4GZ/dPZZf--