Re: [PATCH v3] opcodes: cris: move desc & opc files from sim/

[Hans-Peter Nilsson via Gdb-patches <gdb-patches@sourceware.org>]

> From: Mike Frysinger <vapier@gentoo.org>
> Date: Mon, 24 May 2021 03:23:35 +0200

 From the other mail:
  > On 23 May 2021 22:52, Hans-Peter Nilsson wrote:

> > Missing ChangeLog entries.  Those are "still" kept for opcodes/.
> 
> i don't waste time on these until i actually push the change

They're usually subject to review too, not the least since
people tend to forget them in these cross-project events.

> > All other cgen ports keep their desc & opc files under opcodes/, so
> > move the cris files over too.  The cris-opc.c file is already here.
> 
> The commit log is not updated since the first version:
> cris-opc.c isn't just "already there", it's "not generated by CGEN".

> not sure what you mean.  desc/opc files belong in the opcodes project.  i'm
> explaining why this commit is only moving opc.h and not opc.c in this commit.

And since you're dealing with cgen-generated files, there's
a brief ambiguity (whether "already there" means an orphaned
generated file or what you explain) one that would be
resolved by, as I implied, replacing or appending your
"already there" with "not generated by CGEN".

> if you want me to write something else here, just lemme know what you want
> it to say.

See above: "The cris-opc.c file is already here and not
generated by CGEN".  This'd also explains the reason for the
cgen.sh tweak.

Ok with that, after a cris-elf testsuite run (gas, binutils,
ld, sim), thanks.

brgds, H-P