From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QZlCKtwEq2DlRAAAWB0awg (envelope-from ) for ; Sun, 23 May 2021 21:43:56 -0400 Received: by simark.ca (Postfix, from userid 112) id A4F121F11C; Sun, 23 May 2021 21:43:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0F9291E01F for ; Sun, 23 May 2021 21:43:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB0DA3851C34; Mon, 24 May 2021 01:43:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB0DA3851C34 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1621820635; bh=6/NjyusKmbM1/Rn3d79+r9rRMhMUKUsROT0VVpL+eos=; h=To:In-Reply-To:Subject:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=XP2bVzf/LUeSNj6wvsJEsm8bn/nWjEOID1eAoezqIiQunjt8zCXj3WZapkHbi5zIz eDr7i2zqgJT64eCcThWXnjNnRnsNetR8unRKYHpjUUcHbFjRn/3UxiKItSOw347gLO l4cGcoje503lqo1wL2AhLuDrfEoOtdpDA9Io9zzU= Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by sourceware.org (Postfix) with ESMTPS id D4310385481D; Mon, 24 May 2021 01:43:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D4310385481D To: Mike Frysinger In-Reply-To: <20210524012335.19252-1-vapier@gentoo.org> (message from Mike Frysinger on Mon, 24 May 2021 03:23:35 +0200) Subject: Re: [PATCH v3] opcodes: cris: move desc & opc files from sim/ MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20210523041251.28720-1-vapier@gentoo.org> <20210524012335.19252-1-vapier@gentoo.org> Message-ID: <20210524014351.3ED0D203C6@pchp3.se.axis.com> Date: Mon, 24 May 2021 03:43:51 +0200 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Hans-Peter Nilsson via Gdb-patches Reply-To: Hans-Peter Nilsson Cc: binutils@sourceware.org, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > From: Mike Frysinger > Date: Mon, 24 May 2021 03:23:35 +0200 From the other mail: > On 23 May 2021 22:52, Hans-Peter Nilsson wrote: > > Missing ChangeLog entries. Those are "still" kept for opcodes/. > > i don't waste time on these until i actually push the change They're usually subject to review too, not the least since people tend to forget them in these cross-project events. > > All other cgen ports keep their desc & opc files under opcodes/, so > > move the cris files over too. The cris-opc.c file is already here. > > The commit log is not updated since the first version: > cris-opc.c isn't just "already there", it's "not generated by CGEN". > not sure what you mean. desc/opc files belong in the opcodes project. i'm > explaining why this commit is only moving opc.h and not opc.c in this commit. And since you're dealing with cgen-generated files, there's a brief ambiguity (whether "already there" means an orphaned generated file or what you explain) one that would be resolved by, as I implied, replacing or appending your "already there" with "not generated by CGEN". > if you want me to write something else here, just lemme know what you want > it to say. See above: "The cris-opc.c file is already here and not generated by CGEN". This'd also explains the reason for the cgen.sh tweak. Ok with that, after a cris-elf testsuite run (gas, binutils, ld, sim), thanks. brgds, H-P