Re: [PATCH v2] opcodes: cris: move desc & opc files from sim/

[Hans-Peter Nilsson via Gdb-patches <gdb-patches@sourceware.org>]

Three minor issues:

> From: Mike Frysinger <vapier@gentoo.org>
> Date: Sun, 23 May 2021 06:12:51 +0200

Missing ChangeLog entries.  Those are "still" kept for opcodes/.

> All other cgen ports keep their desc & opc files under opcodes/, so
> move the cris files over too.  The cris-opc.c file is already here.

The commit log is not updated since the first version:
cris-opc.c isn't just "already there", it's "not generated by CGEN".

> diff --git a/opcodes/Makefile.am b/opcodes/Makefile.am
> @@ -431,6 +435,16 @@ stamp-bpf: $(CGENDEPS) $(CPUDIR)/bpf.cpu $(CPUDIR)/bpf.opc
>  	$(MAKE) run-cgen arch=bpf prefix=bpf \
>  		archfile=$(CPUDIR)/bpf.cpu opcfile=$(CPUDIR)/bpf.opc
>  
> +$(srcdir)/cris-desc.h $(srcdir)/cris-desc.c $(srcdir)/cris-opc.h \
> +		$(srcdir)/cris-opc.c $(srcdir)/cris-dis.c: $(CRIS_DEPS)

This dependency isn't updated; cris-opc.c must not depend on
$(CRIS_DEPS) (stamp-cris in maintainer-mode).

Thanks for looking into and finding the CGEN guile-1.8 requirement.
(Is there a CGEN/scheme hacker listening?)

brgds, H-P