From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZO2/Op7AqmDmOwAAWB0awg (envelope-from ) for ; Sun, 23 May 2021 16:52:46 -0400 Received: by simark.ca (Postfix, from userid 112) id E26F21F11C; Sun, 23 May 2021 16:52:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 216891E01F for ; Sun, 23 May 2021 16:52:46 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 82213385743E; Sun, 23 May 2021 20:52:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 82213385743E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1621803164; bh=+ikAiBt+0zfknaKJMg61JPztmTUxNQw8ISKE+1Eegt0=; h=To:In-Reply-To:Subject:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=qQ+fTHqH8W5df39ssDCL2wDioAms0V8/nVdOHSjMM322phEjjSHpYqJLN5TtkiOhz sn3khXt95OQTYCPUYMV6Hhfb3Ws00di9pzJSVImtnKfLXBmtwQcE6rsFcNDlhQ9YZV mE3CC/ndwcY+XyEF5mfC66eO8XwA2K9N7tmthP2g= Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by sourceware.org (Postfix) with ESMTPS id 4A58A3857C50; Sun, 23 May 2021 20:52:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4A58A3857C50 To: Mike Frysinger In-Reply-To: <20210523041251.28720-1-vapier@gentoo.org> (message from Mike Frysinger on Sun, 23 May 2021 06:12:51 +0200) Subject: Re: [PATCH v2] opcodes: cris: move desc & opc files from sim/ MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20210523041251.28720-1-vapier@gentoo.org> Message-ID: <20210523205239.907C5203C1@pchp3.se.axis.com> Date: Sun, 23 May 2021 22:52:39 +0200 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Hans-Peter Nilsson via Gdb-patches Reply-To: Hans-Peter Nilsson Cc: binutils@sourceware.org, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Three minor issues: > From: Mike Frysinger > Date: Sun, 23 May 2021 06:12:51 +0200 Missing ChangeLog entries. Those are "still" kept for opcodes/. > All other cgen ports keep their desc & opc files under opcodes/, so > move the cris files over too. The cris-opc.c file is already here. The commit log is not updated since the first version: cris-opc.c isn't just "already there", it's "not generated by CGEN". > diff --git a/opcodes/Makefile.am b/opcodes/Makefile.am > @@ -431,6 +435,16 @@ stamp-bpf: $(CGENDEPS) $(CPUDIR)/bpf.cpu $(CPUDIR)/bpf.opc > $(MAKE) run-cgen arch=bpf prefix=bpf \ > archfile=$(CPUDIR)/bpf.cpu opcfile=$(CPUDIR)/bpf.opc > > +$(srcdir)/cris-desc.h $(srcdir)/cris-desc.c $(srcdir)/cris-opc.h \ > + $(srcdir)/cris-opc.c $(srcdir)/cris-dis.c: $(CRIS_DEPS) This dependency isn't updated; cris-opc.c must not depend on $(CRIS_DEPS) (stamp-cris in maintainer-mode). Thanks for looking into and finding the CGEN guile-1.8 requirement. (Is there a CGEN/scheme hacker listening?) brgds, H-P