Re: RFA: m32r sim: Add prototypes for functions that pass/return DI values

[Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>]

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

On 11 Nov 2020 15:33, Nick Clifton via Gdb-patches wrote:
> > This kind of problem bit us in the past in GDB too.  I'd suggest trying
> > to make the sim build system enable any or all of these warnings to
> > catch such problems.
> > 
> >    -Wmissing-declarations
> >    -Wmissing-prototypes
> >    -Wold-style-declaration
> >    -Wold-style-definition
> >    -Wstrict-prototypes
> 
> I think that this would be an excellent idea.  Although I think
> that it might cause a lot of work for the maintainers of cgen
> based simulators.

well i've turned on the full set of warnings (copied from gdb in days
past) for all sim ports now :).  when possible, i've turned on -Werror,
but you're right that all the cgen ports need a lot of love ...

i see gdb has split their warning code out into gdbsupport/.  i wonder
if we can reuse that, or maybe just sync the updated set of warnings.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]