From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SDSEBLh4/l+IYwAAWB0awg (envelope-from ) for ; Tue, 12 Jan 2021 23:36:08 -0500 Received: by simark.ca (Postfix, from userid 112) id 101851EF7E; Tue, 12 Jan 2021 23:36:08 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EA2791EF7C for ; Tue, 12 Jan 2021 23:36:03 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 65DB63858D33; Wed, 13 Jan 2021 04:36:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 65DB63858D33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610512563; bh=A9DhRSBeITTaJbq/Z6bV6s7Y31M/lbnRdGW71eXclqU=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Dk1RqrMGMfNzSwm9XuHsZRK78/1XPRZvB7Luw4HEqYgAKFu0mi8WwIhtHjHx2rXX/ y0uxb4s5Sl6XnslwB/9GzSOfy1VKPOZGlMLzNwooUwQR3jZbxZc92GsQhQ6QiarUG5 IUONZEINeHfd5mfZh4GAn+nKmAfiPQV981n4/FBw= Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 4E8D43858D33 for ; Wed, 13 Jan 2021 04:36:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4E8D43858D33 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 213F2340CB6; Wed, 13 Jan 2021 04:35:59 +0000 (UTC) Date: Tue, 12 Jan 2021 23:35:58 -0500 To: Nick Clifton Subject: Re: RFA: m32r sim: Add prototypes for functions that pass/return DI values Message-ID: <20210113043558.GB6938@vapier> Mail-Followup-To: Nick Clifton , Simon Marchi , dje@sebabeach.org, andrew.burgess@embecosm.com, gdb-patches@sourceware.org, law@redhat.com References: <87ft5hhzwo.fsf@redhat.com> <682bf449-242f-8200-df3e-44cad1173ab9@simark.ca> <31ff7443-51c4-04a0-8463-39732a5f7a00@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Bn2rw/3z4jIqBvZU" Content-Disposition: inline In-Reply-To: <31ff7443-51c4-04a0-8463-39732a5f7a00@redhat.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: Simon Marchi , gdb-patches@sourceware.org, dje@sebabeach.org, law@redhat.com Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" --Bn2rw/3z4jIqBvZU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 11 Nov 2020 15:33, Nick Clifton via Gdb-patches wrote: > > This kind of problem bit us in the past in GDB too. I'd suggest trying > > to make the sim build system enable any or all of these warnings to > > catch such problems. > >=20 > > -Wmissing-declarations > > -Wmissing-prototypes > > -Wold-style-declaration > > -Wold-style-definition > > -Wstrict-prototypes >=20 > I think that this would be an excellent idea. Although I think > that it might cause a lot of work for the maintainers of cgen > based simulators. well i've turned on the full set of warnings (copied from gdb in days past) for all sim ports now :). when possible, i've turned on -Werror, but you're right that all the cgen ports need a lot of love ... i see gdb has split their warning code out into gdbsupport/. i wonder if we can reuse that, or maybe just sync the updated set of warnings. -mike --Bn2rw/3z4jIqBvZU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAl/+eK4ACgkQQWM7n+g3 9YFwOw//TlF+DsO6fDNik+foa1LoEXj8IybIWIPpWlk/7vqwKtouMuIX8t85I8gB FZmpNbCMfTOXIVfhHhqIn/hJ9dbDzGQ4mUztPqQ/W/kfWnKCXsBJrJ6jgGzYwC+J ukbfm34laNBzbFMlOGJMpOOdt05b4RmYVGCkuBlH3YjIEsY5PP29SIFyXR61wKuI 3+c8awVrgDn8rhViKAEZoKTg7Wl0od4RQcYt8eqSSkeOxcb66Yx6ite3+23b2INz EbLReWFd0FATYzzaRCSdhk/ipf8jNObyZasthV6sIvO7LdOFz/DayL9GN0WL6HvM 9oJNrO6p/mbmgw/whf1gG0dcO120Qjcld+1NNxHYPeBwXKkQC9+bfl6B5l74v2Ci uVcnoBa0sDmCnbi21W1iWETVOuANNGmCWrvtQ8/18eujR1m7cScWdYByZ0re7PT6 gC/JxtLTqumIQJHTRF5A2y6Z1XezaNBMTf+TwRMkcmz0S8Ui9A/vcQe4ecuPcGRH rBwOMm1U7bPxXOGkkmMkiP/+P0bd36gz/v/ZB5khCQpvVmId1YfgYH2wnj7d66mR 7QB3pHKMHaV0VKZwhKsqIttq+hFxTlFeNR/u6WMk2VrP62ydlPXzt428ArMmVT+P 86m8Qbv47xJ+cuXwd01yyOInyXEEF1ToZETdZ5C2FMuHGtGCeJI= =l3WZ -----END PGP SIGNATURE----- --Bn2rw/3z4jIqBvZU--