Re: RFA: m32r sim: Add prototypes for functions that pass/return DI values

[Simon Marchi <simark@simark.ca>]

On 2020-11-10 12:42 p.m., Nick Clifton via Gdb-patches wrote:
> Hi Doug, Hi Andrew,
>
>   Jeff Law has tracked down a set of problems with the m32r simulator
>   which turned out to be because the m32rbf_h_accum_get_handler()
>   function returns a DI value, but it was not prototyped.  So callers
>   would assume that it returned an int, and happiness ensued...
>
>   I am proposing the attached patch as a workaround for the problem.  A
>   proper fix would be to update the scheme files used to generate the
>   cpu headers.  But I am not a scheme programmer, and besides getting
>   cgen to work with modern versions of guile seems to be quite
>   difficult.  So instead the patch adds prototypes into one of the m32r
>   sim header files that is not auto-generated.
>
>   OK to apply ?
>
> Cheers
>   Nick

This kind of problem bit us in the past in GDB too.  I'd suggest trying
to make the sim build system enable any or all of these warnings to
catch such problems.

  -Wmissing-declarations
  -Wmissing-prototypes
  -Wold-style-declaration
  -Wold-style-definition
  -Wstrict-prototypes

Simon