From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: cgen: move cgen_cpu_max_extra_bytes logic into the common code
Date: Mon, 11 Jan 2021 17:07:56 -0500 [thread overview]
Message-ID: <20210111220756.GV7494@vapier> (raw)
In-Reply-To: <20210111110143.GB1151657@embecosm.com>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
On 11 Jan 2021 11:01, Andrew Burgess wrote:
> * Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> [2021-01-10 03:25:03 -0500]:
>
> > Every arch handles this the same way, so move it to the common code.
> > This will also make unifying the sim_cpu structure easier.
>
> Please can you include the ChangeLog entries with the patch
> submissions.
>
> Could we not remove the `extra_bytes` parameter from sim_cpu_alloc_all
> now? As far as I can tell it is always passed as 0? Or have I missed
> something?
it is technically an exported API, but we haven't really been
guaranteeing ABI stability anywhere as it's a static lib. i
was being a bit conservative, but maybe it's overly so since
no other consumers have shown up in decades.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-01-11 22:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 8:25 Mike Frysinger via Gdb-patches
2021-01-11 11:01 ` Andrew Burgess
2021-01-11 22:07 ` Mike Frysinger via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111220756.GV7494@vapier \
--to=gdb-patches@sourceware.org \
--cc=andrew.burgess@embecosm.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox