From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id REt6BkTM/F8jKAAAWB0awg (envelope-from ) for ; Mon, 11 Jan 2021 17:08:04 -0500 Received: by simark.ca (Postfix, from userid 112) id 0CBC31EEEF; Mon, 11 Jan 2021 17:08:04 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B2B3E1E4F4 for ; Mon, 11 Jan 2021 17:08:03 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6C415384640F; Mon, 11 Jan 2021 22:08:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6C415384640F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610402882; bh=D2D2wb5Uic1Ab1aFtDw9ICo0ZzUmAbgwww/MroZkP/M=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ouwLBcIykBzuvOXYWrz2whLRXA24iQcI7QkJJMVdfLUsaplIsWFN8tg/zYm4LZ17K q25coCD6hK57YbNFgOxphMvlEPGbCJxu+Mklpta/BPGcQ62JGy1Tn0IzeKcwqFN5jD TIsqlinwWKVrrulfzcu7u5akGymah9MEhrGlb2Bc= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 47C51384640F for ; Mon, 11 Jan 2021 22:07:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 47C51384640F Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 73A79340F9A; Mon, 11 Jan 2021 22:07:57 +0000 (UTC) Date: Mon, 11 Jan 2021 17:07:56 -0500 To: Andrew Burgess Subject: Re: [PATCH] sim: cgen: move cgen_cpu_max_extra_bytes logic into the common code Message-ID: <20210111220756.GV7494@vapier> Mail-Followup-To: Andrew Burgess , gdb-patches@sourceware.org References: <20210110082503.20886-1-vapier@gentoo.org> <20210111110143.GB1151657@embecosm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jfWagoTHmfL/c8Ax" Content-Disposition: inline In-Reply-To: <20210111110143.GB1151657@embecosm.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" --jfWagoTHmfL/c8Ax Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 11 Jan 2021 11:01, Andrew Burgess wrote: > * Mike Frysinger via Gdb-patches [2021-01-10= 03:25:03 -0500]: >=20 > > Every arch handles this the same way, so move it to the common code. > > This will also make unifying the sim_cpu structure easier. >=20 > Please can you include the ChangeLog entries with the patch > submissions. >=20 > Could we not remove the `extra_bytes` parameter from sim_cpu_alloc_all > now? As far as I can tell it is always passed as 0? Or have I missed > something? it is technically an exported API, but we haven't really been guaranteeing ABI stability anywhere as it's a static lib. i was being a bit conservative, but maybe it's overly so since no other consumers have shown up in decades. -mike --jfWagoTHmfL/c8Ax Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAl/8zDwACgkQQWM7n+g3 9YF02g//cpEdvSy9HxyORG1duUm99L1d2DBXd5A+GjECrQXKxVvI37CAoV01M3sY HOS5x2m8MxZHHFh4vfInAidbc439cdRFrzT+V6ua8fy/MdLYq1p08FIYTLHVn5K5 wnEcl591lGy9RBWvsKaRcop2xrzqLz96P44fLj74mU3S6zgSW2zlu6zlh6YXbs7Y +g9ZYoPTHvXamyoJpFwgMnK/CfUF8tCuf4xnjTWWU2NPHkx/O5Twb4yWCxLKn+UF xedn5YwdQZsi3+SokcMRDHTLKUqohYtwR+1kZ43ueOqREAeBCqatf01/TkzAXac0 eZHtWF+1oxrvcqaJqFBu9EfsKUff7rL7heToK+LuRM/TnrjIXyfKtIzcJqThCW1l E5drmlBMvrDWqasW6nPEO9/8WI3++1uBclTzbLY4iNG6ojdgcRuxexFpKLraDL3s QESj/wQA5cV5Al/AOpjaKYQ/cVC8hR/EyGz8koSpastQ3OLXO60ptlVoToTMif3E EjSwsKaZM+HaTL9j6P/nFtNuwAZ5tUfPzonr7kyC1NQO6tp1/fxXsgQp8eSpQimZ IN9CFvAW/89ZS4OQgK8+dnvWvnd7aheHqH93U84xyYcV/iWT6dAjqOEmYsGVHMLG 2vK7jLjeIXSh39zcGvHSnKJ9GWDQlD6xpxK/S0ft3XMXdexbhf4= =5wlO -----END PGP SIGNATURE----- --jfWagoTHmfL/c8Ax--