[PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS

[PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS

[Samuel Thibault via Gdb-patches]

gnu-nat.c was getting the inclusion of vm_param.h only by luck. We
need to explicitly include it to be sure to get the definitions of
VM_MIN/MAX_ADDRESS.

gdb/ChangeLog:

        * gnu-nat.c: Include <mach/vm_param.h>.

diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
index 1693ce0c43..6f290be0d5 100644
--- a/gdb/gnu-nat.c
+++ b/gdb/gnu-nat.c
@@ -32,6 +32,7 @@ extern "C"
 #include <mach/message.h>
 #include <mach/notify.h>
 #include <mach/vm_attributes.h>
+#include <mach/vm_param.h>
 
 #include <hurd.h>
 #include <hurd/interrupt.h>

Re: [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS

[Simon Marchi via Gdb-patches]

On 2020-12-21 12:59 p.m., Samuel Thibault via Gdb-patches wrote:
> gnu-nat.c was getting the inclusion of vm_param.h only by luck. We
> need to explicitly include it to be sure to get the definitions of
> VM_MIN/MAX_ADDRESS.
> 
> gdb/ChangeLog:
> 
>         * gnu-nat.c: Include <mach/vm_param.h>.
> 
> diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
> index 1693ce0c43..6f290be0d5 100644
> --- a/gdb/gnu-nat.c
> +++ b/gdb/gnu-nat.c
> @@ -32,6 +32,7 @@ extern "C"
>  #include <mach/message.h>
>  #include <mach/notify.h>
>  #include <mach/vm_attributes.h>
> +#include <mach/vm_param.h>
>  
>  #include <hurd.h>
>  #include <hurd/interrupt.h>
> 

Thanks, this is ok.

Simon

Re: [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS

[Samuel Thibault via Gdb-patches]

(For the record, I don't have commit access).

Simon Marchi, le lun. 21 déc. 2020 14:40:31 -0500, a ecrit:
> 
> 
> On 2020-12-21 12:59 p.m., Samuel Thibault via Gdb-patches wrote:
> > gnu-nat.c was getting the inclusion of vm_param.h only by luck. We
> > need to explicitly include it to be sure to get the definitions of
> > VM_MIN/MAX_ADDRESS.
> > 
> > gdb/ChangeLog:
> > 
> >         * gnu-nat.c: Include <mach/vm_param.h>.
> > 
> > diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
> > index 1693ce0c43..6f290be0d5 100644
> > --- a/gdb/gnu-nat.c
> > +++ b/gdb/gnu-nat.c
> > @@ -32,6 +32,7 @@ extern "C"
> >  #include <mach/message.h>
> >  #include <mach/notify.h>
> >  #include <mach/vm_attributes.h>
> > +#include <mach/vm_param.h>
> >  
> >  #include <hurd.h>
> >  #include <hurd/interrupt.h>
> > 
> 
> Thanks, this is ok.
> 
> Simon
> 

Re: [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS OFF TOPIC PRAISE

[Joshua Branson via Gdb-patches]

I vote we give Samuel commit access!  His genius deserves to be
recognized.  All in favor, say aye!

--
Joshua Branson
Sent from Emacs and Gnus
  https://gnucode.me
  https://video.hardlimit.com/accounts/joshua_branson/video-channels
  https://propernaming.org
  "You can have whatever you want, as long as you help

enough other people get what they want." - Zig Ziglar

Re: [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS OFF TOPIC PRAISE

[Simon Marchi via Gdb-patches]

On 2020-12-22 6:24 p.m., Joshua Branson wrote:
> 
> I vote we give Samuel commit access!  His genius deserves to be
> recognized.  All in favor, say aye!

Sure.  Samuel, would you like to have push access for GDB?  Do you already have a Sourceware account?

Simon

Re: [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS OFF TOPIC PRAISE

[Samuel Thibault via Gdb-patches]

Simon Marchi, le mar. 22 déc. 2020 19:09:17 -0500, a ecrit:
> Samuel, would you like to have push access for GDB?

That could make things simpler, yes.

> Do you already have a Sourceware account?

Yes, 

ssh://sthibaul@sourceware.org

Samuel

Re: [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS OFF TOPIC PRAISE

[Simon Marchi via Gdb-patches]

On 2020-12-22 7:39 p.m., Samuel Thibault wrote:
> Simon Marchi, le mar. 22 déc. 2020 19:09:17 -0500, a ecrit:
>> Samuel, would you like to have push access for GDB?
> 
> That could make things simpler, yes.
> 
>> Do you already have a Sourceware account?
> 
> Yes, 
> 
> ssh://sthibaul@sourceware.org
> 
> Samuel
> 

I've been told you now have push access, give it a try.  The push URL is found here:

https://www.gnu.org/software/gdb/current/

Simon

Re: [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS OFF TOPIC PRAISE

[Samuel Thibault via Gdb-patches]

Hello,

Simon Marchi, le mar. 22 déc. 2020 22:02:40 -0500, a ecrit:
> I've been told you now have push access, give it a try.

Yep it worked, thanks!

Samuel

Re: [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS OFF TOPIC PRAISE

[Simon Marchi via Gdb-patches]

On 2020-12-23 12:01 p.m., Samuel Thibault wrote:
> Hello,
> 
> Simon Marchi, le mar. 22 déc. 2020 22:02:40 -0500, a ecrit:
>> I've been told you now have push access, give it a try.
> 
> Yep it worked, thanks!
> 
> Samuel
> 

Nice!  Please also commit the ChangeLog entry to the correct
ChangeLog file.

Also, you can add yourself to gdb/MAINTAINERS.

Simon

Re: [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS OFF TOPIC PRAISE

[Samuel Thibault via Gdb-patches]

Simon Marchi, le mer. 23 déc. 2020 12:07:21 -0500, a ecrit:
> Please also commit the ChangeLog entry to the correct
> ChangeLog file.

Ah, right.

> Also, you can add yourself to gdb/MAINTAINERS.

Done so.

Samuel