From: Samuel Thibault via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: bug-hurd@gnu.org, Thomas Schwinge <thomas@codesourcery.com>,
gdb-patches@sourceware.org, thomas@schwinge.name
Subject: Re: [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS
Date: Tue, 22 Dec 2020 23:39:07 +0100 [thread overview]
Message-ID: <20201222223907.glamedrblb5hpuux@function> (raw)
In-Reply-To: <b8b5cef1-9459-0bac-146c-bf275a76ddd4@polymtl.ca>
(For the record, I don't have commit access).
Simon Marchi, le lun. 21 déc. 2020 14:40:31 -0500, a ecrit:
>
>
> On 2020-12-21 12:59 p.m., Samuel Thibault via Gdb-patches wrote:
> > gnu-nat.c was getting the inclusion of vm_param.h only by luck. We
> > need to explicitly include it to be sure to get the definitions of
> > VM_MIN/MAX_ADDRESS.
> >
> > gdb/ChangeLog:
> >
> > * gnu-nat.c: Include <mach/vm_param.h>.
> >
> > diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
> > index 1693ce0c43..6f290be0d5 100644
> > --- a/gdb/gnu-nat.c
> > +++ b/gdb/gnu-nat.c
> > @@ -32,6 +32,7 @@ extern "C"
> > #include <mach/message.h>
> > #include <mach/notify.h>
> > #include <mach/vm_attributes.h>
> > +#include <mach/vm_param.h>
> >
> > #include <hurd.h>
> > #include <hurd/interrupt.h>
> >
>
> Thanks, this is ok.
>
> Simon
>
next prev parent reply other threads:[~2020-12-22 22:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 17:59 Samuel Thibault via Gdb-patches
2020-12-21 19:40 ` Simon Marchi via Gdb-patches
2020-12-22 22:39 ` Samuel Thibault via Gdb-patches [this message]
2020-12-22 23:24 ` [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS OFF TOPIC PRAISE Joshua Branson via Gdb-patches
2020-12-23 0:09 ` Simon Marchi via Gdb-patches
2020-12-23 0:39 ` Samuel Thibault via Gdb-patches
2020-12-23 3:02 ` Simon Marchi via Gdb-patches
2020-12-23 17:01 ` Samuel Thibault via Gdb-patches
2020-12-23 17:07 ` Simon Marchi via Gdb-patches
2020-12-23 17:22 ` Samuel Thibault via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201222223907.glamedrblb5hpuux@function \
--to=gdb-patches@sourceware.org \
--cc=bug-hurd@gnu.org \
--cc=samuel.thibault@gnu.org \
--cc=simon.marchi@polymtl.ca \
--cc=thomas@codesourcery.com \
--cc=thomas@schwinge.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox