Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Gareth Rees <grees@undo.io>,
	Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Fix from_tty argument to gdb.execute in Python.
Date: Sat, 26 Sep 2020 11:07:00 -0700	[thread overview]
Message-ID: <20200926180700.GD13066@adacore.com> (raw)
In-Reply-To: <CAA8DSpGOwwr2inQjsSDp+oaY0HJPGN-YKjPsfCc3gzdVCZ46aQ@mail.gmail.com>

> > LGTM.  Do you have commit access to push this?
> >
> 
> Thanks for reviewing. I don't have commit access. Also, I haven't signed
> any copyright assignment documents yet.

Thanks for letting us know about the copyright assignment issue.
For this patch, it's sufficiently small that we can accept it
without the assignment.

There is one small change I made prior to pushing it: I added
a reference to the PR in the ChangeLog and the revision log
(as "PR python/26586" at the start of each ChangeLog entry),
so as to make sure the commit gets linked in the bugzilla PR.

@Andrew, would you agree that this patch would be safe enough
for backporting to the gdb-10-branch?

Thanks,
-- 
Joel

  reply	other threads:[~2020-09-26 18:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 10:23 Gareth Rees
2020-09-22 13:51 ` Andrew Burgess
2020-09-22 15:58   ` Gareth Rees
2020-09-23 11:20     ` Gareth Rees
2020-09-24 11:09       ` Andrew Burgess
2020-09-24 11:16         ` Gareth Rees
2020-09-25 12:53           ` Andrew Burgess
2020-09-25 14:31             ` Gareth Rees
2020-09-26 18:07               ` Joel Brobecker [this message]
2020-09-27 16:39                 ` Andrew Burgess
2020-09-28 20:16                   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200926180700.GD13066@adacore.com \
    --to=brobecker@adacore.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=grees@undo.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox