Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gareth Rees <grees@undo.io>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Fix from_tty argument to gdb.execute in Python.
Date: Tue, 22 Sep 2020 16:58:16 +0100	[thread overview]
Message-ID: <CAA8DSpGL9W0Nm8=kdr_UDDB1uJmd6iGyxoSosfT3-m5C4OuHnw@mail.gmail.com> (raw)
In-Reply-To: <20200922135157.GH1540618@embecosm.com>

Andrew Burgess wrote:

> I'm happy with the change to instream being moved, however, I'm not
> sure about the other two lines.


I moved the entire block of settings changes from
execute_control_commands() back to execute_user_command(), because none of
the changes was mentioned in the commit message for 56bcdbea2b, so that all
these changes seemed to be accidental consequences of supporting multi-line
statements.

I'd be happy to resubmit the patch with just the instream change — that's
the only one of the settings that I need to get from_tty working again.

  reply	other threads:[~2020-09-22 15:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 10:23 Gareth Rees
2020-09-22 13:51 ` Andrew Burgess
2020-09-22 15:58   ` Gareth Rees [this message]
2020-09-23 11:20     ` Gareth Rees
2020-09-24 11:09       ` Andrew Burgess
2020-09-24 11:16         ` Gareth Rees
2020-09-25 12:53           ` Andrew Burgess
2020-09-25 14:31             ` Gareth Rees
2020-09-26 18:07               ` Joel Brobecker
2020-09-27 16:39                 ` Andrew Burgess
2020-09-28 20:16                   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA8DSpGL9W0Nm8=kdr_UDDB1uJmd6iGyxoSosfT3-m5C4OuHnw@mail.gmail.com' \
    --to=grees@undo.io \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox