From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id d+75AEqDb19YSgAAWB0awg (envelope-from ) for ; Sat, 26 Sep 2020 14:07:06 -0400 Received: by simark.ca (Postfix, from userid 112) id E89001EF4D; Sat, 26 Sep 2020 14:07:05 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1C7391E509 for ; Sat, 26 Sep 2020 14:07:05 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C77AE38708C4; Sat, 26 Sep 2020 18:07:04 +0000 (GMT) Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id 788BB38708C4 for ; Sat, 26 Sep 2020 18:07:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 788BB38708C4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 287E71166EC; Sat, 26 Sep 2020 14:07:02 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id DAUWn5GSApnh; Sat, 26 Sep 2020 14:07:02 -0400 (EDT) Received: from takamaka.brobecker.org (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id ED1111166E9; Sat, 26 Sep 2020 14:07:01 -0400 (EDT) Received: by takamaka.brobecker.org (Postfix, from userid 1000) id 57992849D3; Sat, 26 Sep 2020 11:07:00 -0700 (PDT) Date: Sat, 26 Sep 2020 11:07:00 -0700 From: Joel Brobecker To: Gareth Rees , Andrew Burgess Subject: Re: [PATCH] gdb: Fix from_tty argument to gdb.execute in Python. Message-ID: <20200926180700.GD13066@adacore.com> References: <20200922102343.8440-1-grees@undo.io> <20200922135157.GH1540618@embecosm.com> <20200924110912.GK1540618@embecosm.com> <20200925125340.GM1540618@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > > LGTM. Do you have commit access to push this? > > > > Thanks for reviewing. I don't have commit access. Also, I haven't signed > any copyright assignment documents yet. Thanks for letting us know about the copyright assignment issue. For this patch, it's sufficiently small that we can accept it without the assignment. There is one small change I made prior to pushing it: I added a reference to the PR in the ChangeLog and the revision log (as "PR python/26586" at the start of each ChangeLog entry), so as to make sure the commit gets linked in the bugzilla PR. @Andrew, would you agree that this patch would be safe enough for backporting to the gdb-10-branch? Thanks, -- Joel