Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: Fredrik Hederstierna <fredrik.hederstierna@verisure.com>,
	"gdb-patches\\@sourceware.org" <gdb-patches@sourceware.org>,
	nd <nd@arm.com>,
	James-Adam Renquinha Henri <arenquinha@cimeq.qc.ca>
Subject: Re: [PATCH] Fix exception stack unwinding for ARM Cortex-M
Date: Mon, 14 Sep 2020 11:31:26 -0700	[thread overview]
Message-ID: <20200914183126.GF5200@adacore.com> (raw)
In-Reply-To: <48292CAD-52D7-4471-97D7-E360C8EF3652@arm.com>

Hi Alan,

> > I do not have any GDB Bugzilla account, so please submit bugs for the additional features.
> 
> Added:
> https://sourceware.org/bugzilla/show_bug.cgi?id=26611
> https://sourceware.org/bugzilla/show_bug.cgi?id=26612
> https://sourceware.org/bugzilla/show_bug.cgi?id=26613
> 
> 
> > It would be great if patch goes in before the GDB 10 branching,
> 
> 
> Joel:
> Is it ok to pull this patch across to GDB 10? (And is that something you do?)
> It’s Arm only, and will only effect programs that are using special stack setups.

As the Area Maintainer for ARM, if the patch looks sufficiently safe
to you, you can approve the backport to a release branch. I'm always
happy to provide a second pair of eyes and an opinion when asked,
but that's not a requirement, simply because I'm not as well versed
in most areas of the code.

Looking at how the patch is written, it's not entirely obvious to me how
this can only affect programs using that special stack setup, but that's
probably because I don't know the ARM architecture as well as you do.
If you're confident about the patch, go ahead.

-- 
Joel


  reply	other threads:[~2020-09-14 18:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AM4PR1001MB0948AC4D9CB635F5A9A2FC82EFDC0@AM4PR1001MB0948.EURPRD10.PROD.OUTLOOK.COM>
     [not found] ` <HE1PR1001MB130613C0995C4C21A630373BEF1B0@HE1PR1001MB1306.EURPRD10.PROD.OUTLOOK.COM>
2019-06-10 21:25   ` [PATCH] Fix exception " James-Adam Renquinha Henri
2019-06-12  9:01     ` Alan Hayward
2020-08-29  8:35       ` [PATCH] Fix exception stack " Fredrik Hederstierna
2020-09-02 13:24         ` Alan Hayward
2020-09-06  9:27           ` Fredrik Hederstierna
2020-09-09  8:12             ` Alan Hayward
2020-09-10 21:00               ` Fredrik Hederstierna
2020-09-14 14:44                 ` Alan Hayward
2020-09-14 18:31                   ` Joel Brobecker [this message]
2020-09-15 14:05                     ` Alan Hayward

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200914183126.GF5200@adacore.com \
    --to=brobecker@adacore.com \
    --cc=Alan.Hayward@arm.com \
    --cc=arenquinha@cimeq.qc.ca \
    --cc=fredrik.hederstierna@verisure.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox