From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id 5C4E63857C62 for ; Mon, 14 Sep 2020 18:31:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5C4E63857C62 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0B584117768; Mon, 14 Sep 2020 14:31:29 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ycuXVK1BqWYz; Mon, 14 Sep 2020 14:31:28 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E5A7A116823; Mon, 14 Sep 2020 14:31:27 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 4586E867E8; Mon, 14 Sep 2020 11:31:26 -0700 (PDT) Date: Mon, 14 Sep 2020 11:31:26 -0700 From: Joel Brobecker To: Alan Hayward Cc: Fredrik Hederstierna , "gdb-patches\\@sourceware.org" , nd , James-Adam Renquinha Henri Subject: Re: [PATCH] Fix exception stack unwinding for ARM Cortex-M Message-ID: <20200914183126.GF5200@adacore.com> References: <790E863F-88F4-47D7-A70A-FA22779ACC2A@arm.com> <04F0F9D3-6A7D-4F6E-8AE7-93F360CEEA91@arm.com> <6AB27C15-60DF-43A2-863A-C250AD034492@arm.com> <48292CAD-52D7-4471-97D7-E360C8EF3652@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <48292CAD-52D7-4471-97D7-E360C8EF3652@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Sep 2020 18:31:30 -0000 Hi Alan, > > I do not have any GDB Bugzilla account, so please submit bugs for the additional features. > > Added: > https://sourceware.org/bugzilla/show_bug.cgi?id=26611 > https://sourceware.org/bugzilla/show_bug.cgi?id=26612 > https://sourceware.org/bugzilla/show_bug.cgi?id=26613 > > > > It would be great if patch goes in before the GDB 10 branching, > > > Joel: > Is it ok to pull this patch across to GDB 10? (And is that something you do?) > It’s Arm only, and will only effect programs that are using special stack setups. As the Area Maintainer for ARM, if the patch looks sufficiently safe to you, you can approve the backport to a release branch. I'm always happy to provide a second pair of eyes and an opinion when asked, but that's not a requirement, simply because I'm not as well versed in most areas of the code. Looking at how the patch is written, it's not entirely obvious to me how this can only affect programs using that special stack setup, but that's probably because I don't know the ARM architecture as well as you do. If you're confident about the patch, go ahead. -- Joel