Re: [PATCH] Fix exception stack unwinding for ARM Cortex-M

[Alan Hayward <Alan.Hayward@arm.com>]

> On 14 Sep 2020, at 19:31, Joel Brobecker <brobecker@adacore.com> wrote:
> 
> Hi Alan,
> 
>>> I do not have any GDB Bugzilla account, so please submit bugs for the additional features.
>> 
>> Added:
>> https://sourceware.org/bugzilla/show_bug.cgi?id=26611
>> https://sourceware.org/bugzilla/show_bug.cgi?id=26612
>> https://sourceware.org/bugzilla/show_bug.cgi?id=26613
>> 
>> 
>>> It would be great if patch goes in before the GDB 10 branching,
>> 
>> 
>> Joel:
>> Is it ok to pull this patch across to GDB 10? (And is that something you do?)
>> It’s Arm only, and will only effect programs that are using special stack setups.
> 
> As the Area Maintainer for ARM, if the patch looks sufficiently safe
> to you, you can approve the backport to a release branch. I'm always
> happy to provide a second pair of eyes and an opinion when asked,
> but that's not a requirement, simply because I'm not as well versed
> in most areas of the code.
> 
> Looking at how the patch is written, it's not entirely obvious to me how
> this can only affect programs using that special stack setup, but that's
> probably because I don't know the ARM architecture as well as you do.
> If you're confident about the patch, go ahead.

Ok, thanks for clearing that up :)

Agreed it’s not immediately obvious, but the new code is all inside if blocks,
with the standard case behaving identical to previously.

I’ve pushed the patch to gdb-10-branch now.


Thanks!
Alan.



> 
> -- 
> Joel