From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simark@simark.ca>, Saagar Jha <saagar@saagarjha.com>
Subject: Re: [PATCH] Rename block.{h,c} to gdb-block.{h, c}
Date: Sun, 6 Sep 2020 19:40:24 -0700 [thread overview]
Message-ID: <20200906194024.4d468901@f32-m1.lan> (raw)
In-Reply-To: <a6663f3d-1aa6-2243-d3e2-5dc6d0cd7fbf@simark.ca>
On Sun, 6 Sep 2020 07:52:36 -0400
Simon Marchi <simark@simark.ca> wrote:
> Renaming our file is a little bit annoying, but I don't see a better
> solution. We could change our includes to be "./block.h" or
> "gdb/block.h", but sooner or later someone will add back a "block.h"
> include. It will silently break macOS because we don't have CI for
> that, and it will take somebody building GDB on macOS to notice and
> fix it.
Offhand, I can't think of a better solution either, but I really don't
like renaming GDB's header files to accomodate MacOS. It seems to me
that we might face future potential confilicts (not just on MacOS)
with several other GDB header files as well, e.g. probe.h, frame.h,
value.h, and possibly others too.
I really think we should look for a better / different solution.
Kevin
prev parent reply other threads:[~2020-09-07 2:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 2:21 Saagar Jha
2020-09-06 11:52 ` Simon Marchi
2020-09-07 1:47 ` Saagar Jha
2020-09-07 2:53 ` Kevin Buettner
2020-09-07 5:27 ` Saagar Jha
2020-09-07 2:40 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200906194024.4d468901@f32-m1.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=saagar@saagarjha.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox