From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 73F263857C44 for ; Mon, 7 Sep 2020 02:40:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 73F263857C44 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-570-_e1ofdG6N5Wrxxzg01dGaw-1; Sun, 06 Sep 2020 22:40:27 -0400 X-MC-Unique: _e1ofdG6N5Wrxxzg01dGaw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 30E8D1074661; Mon, 7 Sep 2020 02:40:26 +0000 (UTC) Received: from f32-m1.lan (ovpn-115-29.phx2.redhat.com [10.3.115.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E0F5C5C225; Mon, 7 Sep 2020 02:40:25 +0000 (UTC) Date: Sun, 6 Sep 2020 19:40:24 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Simon Marchi , Saagar Jha Subject: Re: [PATCH] Rename block.{h,c} to gdb-block.{h, c} Message-ID: <20200906194024.4d468901@f32-m1.lan> In-Reply-To: References: Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Sep 2020 02:40:32 -0000 On Sun, 6 Sep 2020 07:52:36 -0400 Simon Marchi wrote: > Renaming our file is a little bit annoying, but I don't see a better > solution. We could change our includes to be "./block.h" or > "gdb/block.h", but sooner or later someone will add back a "block.h" > include. It will silently break macOS because we don't have CI for > that, and it will take somebody building GDB on macOS to notice and > fix it. Offhand, I can't think of a better solution either, but I really don't like renaming GDB's header files to accomodate MacOS. It seems to me that we might face future potential confilicts (not just on MacOS) with several other GDB header files as well, e.g. probe.h, frame.h, value.h, and possibly others too. I really think we should look for a better / different solution. Kevin