From: Simon Marchi <simark@simark.ca>
To: Saagar Jha <saagar@saagarjha.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Rename block.{h,c} to gdb-block.{h, c}
Date: Sun, 6 Sep 2020 07:52:36 -0400 [thread overview]
Message-ID: <a6663f3d-1aa6-2243-d3e2-5dc6d0cd7fbf@simark.ca> (raw)
In-Reply-To: <D53E5DA4-5504-4A78-B592-DADA8025BEE7@saagarjha.com>
On 2020-09-05 10:21 p.m., Saagar Jha wrote:
> GDB doesn’t build with newer SDKs because its block.h conflicts with macOS’s Block.h. This patch resolves the issue by renaming GDB’s files.
>
Hi,
Can you include in the commit message:
- which SDK are we talking about (for the non-initiated to macOS)
- the relevant versions (macOS, SDK)
Renaming our file is a little bit annoying, but I don't see a better solution. We could
change our includes to be "./block.h" or "gdb/block.h", but sooner or later someone will
add back a "block.h" include. It will silently break macOS because we don't have CI for
that, and it will take somebody building GDB on macOS to notice and fix it.
In your ChangeLog entry, drop the "gdb" part of the filenames, so that they are relative
to the ChangeLog file itself (Makefile.in instead of gdb/Makefile.in).
Simon
next prev parent reply other threads:[~2020-09-06 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 2:21 Saagar Jha
2020-09-06 11:52 ` Simon Marchi [this message]
2020-09-07 1:47 ` Saagar Jha
2020-09-07 2:53 ` Kevin Buettner
2020-09-07 5:27 ` Saagar Jha
2020-09-07 2:40 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6663f3d-1aa6-2243-d3e2-5dc6d0cd7fbf@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=saagar@saagarjha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox