From: Gary Benson <gbenson@redhat.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Disable Clang's integrated assembler for two testcases
Date: Tue, 25 Aug 2020 15:54:33 +0100 [thread overview]
Message-ID: <20200825145433.GB17510@blade.nx> (raw)
In-Reply-To: <08ab4c1d-40ad-8eac-f40e-e880a28f7e30@palves.net>
Pedro Alves wrote:
> On 8/25/20 3:35 PM, Gary Benson wrote:
> >>> * gdb.dwarf2/dw2-dir-file-name.exp: Use system assembler
> >>> when compiling with clang.
> >>> * gdb.dwarf2/dw2-restore.exp: Likewise
> >>
> >> Missing period after "Likewise".
> >
> > I pushed the wrong commit, without the period added. Should I push
> > a correction?
>
> Sure, why not?
Cool, I've done this now. Thanks for you review!
Cheers,
Gary
--
Gary Benson - he / him / his
Principal Software Engineer, Red Hat
prev parent reply other threads:[~2020-08-25 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 14:55 Gary Benson
2020-08-20 12:17 ` Pedro Alves
2020-08-25 14:35 ` Gary Benson
2020-08-25 14:40 ` Pedro Alves
2020-08-25 14:54 ` Gary Benson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825145433.GB17510@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox