Re: [PATCH] Disable Clang's integrated assembler for two testcases

[Pedro Alves <pedro@palves.net>]

On 8/19/20 3:55 PM, Gary Benson via Gdb-patches wrote:
> Hi all,
> 
> gdb.dwarf2/dw2-dir-file-name.exp fails to build using Clang because
> the generated assembly language contains .ascii directives with more
> than one string literal.  gdb.dwarf2/dw2-restore.exp fails to build
> using Clang because it contains .func and .endfunc directives.
> This patch causes Clang to invoke the system assembler to assemble
> the relevant files.
> 
> Checked on Fedora 32 x86_64, GCC and clang.  Ok to commit?

Given we have this in most gdb.dwarf2 tests:

 # This test can only be run on targets which support DWARF-2 and use gas.
                                                              ^^^^^^^^^^^

this seems fine to me.

> 
> Cheers,
> Gary
> 
> --
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.dwarf2/dw2-dir-file-name.exp: Use system assembler
> 	when compiling with clang.
> 	* gdb.dwarf2/dw2-restore.exp: Likewise

Missing period after "Likewise".

Thanks,
Pedro Alves